no log passwords (#21229)

* no log passwords * removed unneeded no_log
2026-05-07 22:02:50 +00:00 · 2017-02-10 15:13:59 -05:00
parent 2f6966965e
commit 74e8aa22af
30 changed files with 36 additions and 43 deletions
--- a/lib/ansible/modules/cloud/azure/azure_rm_virtualmachine.py
+++ b/lib/ansible/modules/cloud/azure/azure_rm_virtualmachine.py
@@ -487,7 +487,7 @@ class AzureRMVirtualMachine(AzureRMModuleBase):
            short_hostname=dict(type='str'),
            vm_size=dict(type='str', choices=[], default='Standard_D1'),
            admin_username=dict(type='str'),
-            admin_password=dict(type='str', ),
+            admin_password=dict(type='str', no_log=True),
            ssh_password_enabled=dict(type='bool', default=True),
            ssh_public_keys=dict(type='list'),
            image=dict(type='dict'),
--- a/lib/ansible/modules/cloud/centurylink/clc_server.py
+++ b/lib/ansible/modules/cloud/centurylink/clc_server.py
@@ -613,7 +613,7 @@ class ClcServer:
            ttl=dict(default=None),
            managed_os=dict(type='bool', default=False),
            description=dict(default=None),
-            source_server_password=dict(default=None),
+            source_server_password=dict(default=None, no_log=True),
            cpu_autoscale_policy_id=dict(default=None),
            anti_affinity_policy_id=dict(default=None),
            anti_affinity_policy_name=dict(default=None),
--- a/lib/ansible/modules/cloud/cloudstack/cs_host.py
+++ b/lib/ansible/modules/cloud/cloudstack/cs_host.py
@@ -505,7 +505,7 @@ def main():
    argument_spec = cs_argument_spec()
    argument_spec.update(dict(
        name=dict(required=True, aliases=['url']),
-        password=dict(default=None, not_log=True),
+        password=dict(default=None, no_log=True),
        username=dict(default=None),
        hypervisor=dict(choices=CS_HYPERVISORS, default=None),
        allocation_state=dict(default=None),
--- a/lib/ansible/modules/cloud/lxd/lxd_container.py
+++ b/lib/ansible/modules/cloud/lxd/lxd_container.py
@@ -599,9 +599,7 @@ def main():
                type='str',
                default='{}/.config/lxc/client.crt'.format(os.environ['HOME'])
            ),
-            trust_password=dict(
-                type='str',
-            )
+            trust_password=dict( type='str', no_log=True )
        ),
        supports_check_mode=False,
    )
--- a/lib/ansible/modules/cloud/lxd/lxd_profile.py
+++ b/lib/ansible/modules/cloud/lxd/lxd_profile.py
@@ -362,9 +362,7 @@ def main():
                type='str',
                default='{}/.config/lxc/client.crt'.format(os.environ['HOME'])
            ),
-            trust_password=dict(
-                type='str',
-            )
+            trust_password=dict( type='str', no_log=True)
        ),
        supports_check_mode=False,
    )
--- a/lib/ansible/modules/cloud/misc/rhevm.py
+++ b/lib/ansible/modules/cloud/misc/rhevm.py
@@ -1485,7 +1485,7 @@ def main():
        argument_spec = dict(
            state      = dict(default='present', choices=['ping', 'present', 'absent', 'up', 'down', 'restarted', 'cd', 'info']),
            user       = dict(default="admin@internal"),
-            password   = dict(required=True),
+            password   = dict(required=True, no_log=True),
            server     = dict(default="127.0.0.1"),
            port       = dict(default="443"),
            insecure_api = dict(default=False, type='bool'),
--- a/lib/ansible/modules/cloud/openstack/os_user.py
+++ b/lib/ansible/modules/cloud/openstack/os_user.py
@@ -182,7 +182,7 @@ def main():

    argument_spec = openstack_full_argument_spec(
        name=dict(required=True),
-        password=dict(required=False, default=None),
+        password=dict(required=False, default=None, no_log=True),
        email=dict(required=False, default=None),
        default_project=dict(required=False, default=None),
        domain=dict(required=False, default=None),
--- a/lib/ansible/modules/cloud/ovirt/ovirt_host_pm.py
+++ b/lib/ansible/modules/cloud/ovirt/ovirt_host_pm.py
@@ -182,7 +182,7 @@ def main():
        name=dict(default=None, required=True, aliases=['host']),
        address=dict(default=None),
        username=dict(default=None),
-        password=dict(default=None),
+        password=dict(default=None, no_log=True),
        type=dict(default=None),
        port=dict(default=None, type='int'),
        slot=dict(default=None),
--- a/lib/ansible/modules/cloud/ovirt/ovirt_hosts.py
+++ b/lib/ansible/modules/cloud/ovirt/ovirt_hosts.py
@@ -316,7 +316,7 @@ def main():
        comment=dict(default=None),
        cluster=dict(default=None),
        address=dict(default=None),
-        password=dict(default=None),
+        password=dict(default=None, no_log=True),
        public_key=dict(default=False, type='bool', aliases=['ssh_public_key']),
        kdump_integration=dict(default=None, choices=['enabled', 'disabled']),
        spm_priority=dict(default=None, type='int'),
--- a/lib/ansible/modules/cloud/profitbricks/profitbricks.py
+++ b/lib/ansible/modules/cloud/profitbricks/profitbricks.py
@@ -598,7 +598,7 @@ def main():
                            default='AMD_OPTERON'),
            volume_size=dict(type='int', default=10),
            disk_type=dict(choices=['HDD', 'SSD'], default='HDD'),
-            image_password=dict(default=None),
+            image_password=dict(default=None, no_log=True),
            ssh_keys=dict(type='list', default=[]),
            bus=dict(choices=['VIRTIO', 'IDE'], default='VIRTIO'),
            lan=dict(type='int', default=1),
@@ -606,7 +606,7 @@ def main():
            auto_increment=dict(type='bool', default=True),
            instance_ids=dict(type='list', default=[]),
            subscription_user=dict(),
-            subscription_password=dict(),
+            subscription_password=dict(no_log=True),
            location=dict(choices=LOCATIONS, default='us/las'),
            assign_public_ip=dict(type='bool', default=False),
            wait=dict(type='bool', default=True),
--- a/lib/ansible/modules/cloud/profitbricks/profitbricks_datacenter.py
+++ b/lib/ansible/modules/cloud/profitbricks/profitbricks_datacenter.py
@@ -212,7 +212,7 @@ def main():
            description=dict(),
            location=dict(choices=LOCATIONS, default='us/las'),
            subscription_user=dict(),
-            subscription_password=dict(),
+            subscription_password=dict(no_log=True),
            wait=dict(type='bool', default=True),
            wait_timeout=dict(default=600),
            state=dict(default='present'),
--- a/lib/ansible/modules/cloud/profitbricks/profitbricks_nic.py
+++ b/lib/ansible/modules/cloud/profitbricks/profitbricks_nic.py
@@ -241,7 +241,7 @@ def main():
            name=dict(default=str(uuid.uuid4()).replace('-','')[:10]),
            lan=dict(),
            subscription_user=dict(),
-            subscription_password=dict(),
+            subscription_password=dict(no_log=True),
            wait=dict(type='bool', default=True),
            wait_timeout=dict(type='int', default=600),
            state=dict(default='present'),
--- a/lib/ansible/modules/cloud/profitbricks/profitbricks_volume.py
+++ b/lib/ansible/modules/cloud/profitbricks/profitbricks_volume.py
@@ -377,7 +377,7 @@ def main():
            size=dict(type='int', default=10),
            bus=dict(choices=['VIRTIO', 'IDE'], default='VIRTIO'),
            image=dict(),
-            image_password=dict(default=None),
+            image_password=dict(default=None, no_log=True),
            ssh_keys=dict(type='list', default=[]),
            disk_type=dict(choices=['HDD', 'SSD'], default='HDD'),
            licence_type=dict(default='UNKNOWN'),
@@ -385,7 +385,7 @@ def main():
            auto_increment=dict(type='bool', default=True),
            instance_ids=dict(type='list', default=[]),
            subscription_user=dict(),
-            subscription_password=dict(),
+            subscription_password=dict(no_log=True),
            wait=dict(type='bool', default=True),
            wait_timeout=dict(type='int', default=600),
            state=dict(default='present'),
--- a/lib/ansible/modules/cloud/profitbricks/profitbricks_volume_attachments.py
+++ b/lib/ansible/modules/cloud/profitbricks/profitbricks_volume_attachments.py
@@ -219,7 +219,7 @@ def main():
            server=dict(),
            volume=dict(),
            subscription_user=dict(),
-            subscription_password=dict(),
+            subscription_password=dict(no_log=True),
            wait=dict(type='bool', default=True),
            wait_timeout=dict(type='int', default=600),
            state=dict(default='present'),
--- a/lib/ansible/modules/cloud/webfaction/webfaction_db.py
+++ b/lib/ansible/modules/cloud/webfaction/webfaction_db.py
@@ -112,7 +112,7 @@ def main():
            state = dict(required=False, choices=['present', 'absent'], default='present'),
            # You can specify an IP address or hostname.
            type = dict(required=True),
-            password = dict(required=False, default=None),
+            password = dict(required=False, default=None, no_log=True),
            login_name = dict(required=True),
            login_password = dict(required=True, no_log=True),
            machine = dict(required=False, default=False),
--- a/lib/ansible/modules/cloud/webfaction/webfaction_mailbox.py
+++ b/lib/ansible/modules/cloud/webfaction/webfaction_mailbox.py
@@ -87,7 +87,7 @@ def main():
    module = AnsibleModule(
        argument_spec=dict(
            mailbox_name=dict(required=True),
-            mailbox_password=dict(required=True),
+            mailbox_password=dict(required=True, no_log=True),
            state=dict(required=False, choices=['present', 'absent'], default='present'),
            login_name=dict(required=True),
            login_password=dict(required=True, no_log=True),