internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-08 06:12:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check return value of get_distribution()

Browse Source 
On none-Linux systems `get_distribution()` returns `None`, which fails in `fetch_url`, because the return value of `get_distribution()` is not checked before calling `lower()` on the result.
This commit is contained in:
Daniel Kempkens
2016-03-16 10:49:21 +01:00
parent 9be6974d37
commit 696b68f07a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/ansible/module_utils/urls.py
View File

@@ -842,7 +842,7 @@ def fetch_url(module, url, data=None, headers=None, method=None,
info.update(dict(msg="OK (%s bytes)" % r.headers.get('Content-Length', 'unknown'), status=200)) info.update(dict(msg="OK (%s bytes)" % r.headers.get('Content-Length', 'unknown'), status=200))
except NoSSLError, e: except NoSSLError, e:
distribution = get_distribution() distribution = get_distribution()
if distribution.lower() == 'redhat': if distribution is not None and distribution.lower() == 'redhat':
module.fail_json(msg='%s. You can also install python-ssl from EPEL' % str(e)) module.fail_json(msg='%s. You can also install python-ssl from EPEL' % str(e))
else: else:
module.fail_json(msg='%s' % str(e)) module.fail_json(msg='%s' % str(e))