Fix dangerous default args. (#29839)

This commit is contained in:
Matt Clay
2017-09-12 00:11:13 -07:00
committed by GitHub
parent 5caa47feb9
commit 68aeaa58a8
50 changed files with 253 additions and 87 deletions

View File

@@ -450,7 +450,9 @@ class Ec2Metadata(object):
data = None
return to_text(data)
def _mangle_fields(self, fields, uri, filter_patterns=['public-keys-0']):
def _mangle_fields(self, fields, uri, filter_patterns=None):
filter_patterns = ['public-keys-0'] if filter_patterns is None else filter_patterns
new_fields = {}
for key, value in fields.items():
split_fields = key[len(uri):].split('/')

View File

@@ -1014,7 +1014,9 @@ class ElbManager(object):
self._delete_policy(self.elb.name, policy)
self._create_policy(policy_param, policy_meth, policy)
def _set_listener_policy(self, listeners_dict, policy=[]):
def _set_listener_policy(self, listeners_dict, policy=None):
policy = [] if policy is None else policy
for listener_port in listeners_dict:
if listeners_dict[listener_port].startswith('HTTP'):
self.elb_conn.set_lb_policies_of_listener(self.elb.name, listener_port, policy)