iosxr implemetation for net_interface (#27513)

* iosxr implemetation for net_interface

*  iosxr_interface implementation

* Add integration test

*  iosxr_interface integration test
*  net_interface intergration test for iosxr

* update boilerplate

test/integration/iosxr.yaml

@@ -78,6 +78,15 @@
             failed_modules: "{{ failed_modules }} + [ 'iosxr_logging' ]"
             test_failed: true
 
+    - block:
+      - include_role:
+          name: iosxr_interface
+        when: "limit_to in ['*', 'iosxr_interface']"
+      rescue:
+        - set_fact:
+            failed_modules: "{{ failed_modules }} + [ 'iosxr_interface' ]"
+            test_failed: true
+
 ###########
     - debug: var=failed_modules
       when: test_failed

test/integration/targets/iosxr_interface/defaults/main.yaml

@@ -0,0 +1,3 @@
+---
+testcase: "*"
+test_items: []

test/integration/targets/iosxr_interface/meta/main.yaml

@@ -0,0 +1,2 @@
+dependencies:
+  - prepare_iosxr_tests

test/integration/targets/iosxr_interface/tasks/cli.yaml

@@ -0,0 +1,16 @@
+---
+- name: collect all cli test cases
+  find:
+    paths: "{{ role_path }}/tests/cli"
+    patterns: "{{ testcase }}.yaml"
+  register: test_cases
+  delegate_to: localhost
+
+- name: set test_items
+  set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"
+
+- name: run test case
+  include: "{{ test_case_to_run }}"
+  with_items: "{{ test_items }}"
+  loop_control:
+    loop_var: test_case_to_run

test/integration/targets/iosxr_interface/tasks/main.yaml

@@ -0,0 +1,2 @@
+---
+- { include: cli.yaml, tags: ['cli'] }

test/integration/targets/iosxr_interface/tests/cli/basic.yaml

@@ -0,0 +1,267 @@
+---
+- debug: msg="START iosxr_interface cli/basic.yaml"
+
+- name: Setup interface
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    state: absent
+    provider: "{{ cli }}"
+  register: result
+
+
+- name: Confgure interface
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    description: test-interface-initial
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/2 description test-interface-initial" in result.commands'
+
+- name: Confgure interface (idempotent)
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    description: test-interface-initial
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == false'
+
+- name: Confgure interface parameters
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    description: test-interface
+    speed: 100
+    duplex: half
+    mtu: 512
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/2 description test-interface" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 speed 100" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 duplex half" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 mtu 512" in result.commands'
+
+- name: Change interface parameters
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    description: test-interface-1
+    speed: 10
+    duplex: full
+    mtu: 256
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/2 description test-interface-1" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 speed 10" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 duplex full" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 mtu 256" in result.commands'
+
+- name: Delete interface parameters
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/2 description configured by iosxr_interface" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/2 speed 10" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/2 duplex full" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/2 mtu 256" in result.commands'
+
+- name: Delete interface parameters (idempotent)
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == false'
+
+- name: Disable interface
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    state: down
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/2 shutdown" in result.commands'
+
+- name: Enable interface
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    state: up
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"no interface GigabitEthernet0/0/0/2 shutdown" in result.commands'
+
+- name: Confgure second interface (setup)
+  net_interface:
+    name: GigabitEthernet0/0/0/3
+    description: test-interface-initial
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/3 description test-interface-initial" in result.commands'
+
+- name: Add interface aggregate
+  net_interface:
+    aggregate:
+    - { name: GigabitEthernet0/0/0/3, speed: 10, duplex: half, mtu: 256, description: test-interface-1 }
+    - { name: GigabitEthernet0/0/0/2, speed: 100, duplex: full, mtu: 516, description: test-interface-2 }
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/3 speed 10" in result.commands'
+      - '"interface GigabitEthernet0/0/0/3 description test-interface-1" in result.commands'
+      - '"interface GigabitEthernet0/0/0/3 duplex half" in result.commands'
+      - '"interface GigabitEthernet0/0/0/3 mtu 256" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 speed 100" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 description test-interface-2" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 duplex full" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 mtu 516" in result.commands'
+
+- name: Add interface aggregate (idempotent)
+  net_interface:
+    aggregate:
+    - { name: GigabitEthernet0/0/0/3, speed: 10, duplex: half, mtu: 256, description: test-interface-1 }
+    - { name: GigabitEthernet0/0/0/2, speed: 100, duplex: full, mtu: 516, description: test-interface-2 }
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == false'
+
+
+- name: Change interface parameters in aggregate
+  net_interface:
+    aggregate:
+    - { name: GigabitEthernet0/0/0/3 }
+    - { name: GigabitEthernet0/0/0/2 }
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"no interface GigabitEthernet0/0/0/3 speed 10" in result.commands'
+      - '"interface GigabitEthernet0/0/0/3 description configured by iosxr_interface" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/3 duplex half" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/3 mtu 256" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/2 speed 100" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 description configured by iosxr_interface" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/2 duplex full" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/2 mtu 516" in result.commands'
+
+- name: Disable interface aggregate
+  net_interface:
+    aggregate:
+    - { name: GigabitEthernet0/0/0/3, state: down }
+    - { name: GigabitEthernet0/0/0/2, state: down }
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/3 shutdown" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 shutdown" in result.commands'
+
+- name: Enable interface aggregate
+  net_interface:
+    aggregate:
+    - { name: GigabitEthernet0/0/0/3, state: up }
+    - { name: GigabitEthernet0/0/0/2, state: up }
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"no interface GigabitEthernet0/0/0/3 shutdown" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/2 shutdown" in result.commands'
+
+- name: Create interface aggregate
+  net_interface:
+    aggregate:
+    - { name: GigabitEthernet0/0/0/4 }
+    - { name: GigabitEthernet0/0/0/5 }
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/4 description configured by iosxr_interface" in result.commands'
+      - '"interface GigabitEthernet0/0/0/5 description configured by iosxr_interface" in result.commands'
+
+- name: Delete interface aggregate
+  net_interface:
+    aggregate:
+    - { name: GigabitEthernet0/0/0/4, state: absent }
+    - { name: GigabitEthernet0/0/0/5, state: absent }
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"no interface GigabitEthernet0/0/0/4" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/5" in result.commands'
+
+- name: Delete interface aggregate (idempotent)
+  net_interface:
+    aggregate:
+    - { name: GigabitEthernet0/0/0/4, state: absent }
+    - { name: GigabitEthernet0/0/0/5, state: absent }
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == false'
+
+- debug: msg="END iosxr_interface cli/basic.yaml"

test/integration/targets/net_interface/tests/cli/basic.yaml

@@ -7,4 +7,7 @@
 - include: "{{ role_path }}/tests/vyos/basic.yaml"
   when: hostvars[inventory_hostname]['ansible_network_os'] == 'vyos'
 
+- include: "{{ role_path }}/tests/iosxr/basic.yaml"
+  when: hostvars[inventory_hostname]['ansible_network_os'] == 'iosxr'
+
 - debug: msg="END cli/contains.yaml"

test/integration/targets/net_interface/tests/iosxr/basic.yaml

@@ -0,0 +1,267 @@
+---
+- debug: msg="START net_interface iosxr/basic.yaml"
+
+- name: Setup interface
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    state: absent
+    provider: "{{ cli }}"
+  register: result
+
+
+- name: Confgure interface
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    description: test-interface-initial
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/2 description test-interface-initial" in result.commands'
+
+- name: Confgure interface (idempotent)
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    description: test-interface-initial
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == false'
+
+- name: Confgure interface parameters
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    description: test-interface
+    speed: 100
+    duplex: half
+    mtu: 512
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/2 description test-interface" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 speed 100" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 duplex half" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 mtu 512" in result.commands'
+
+- name: Change interface parameters
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    description: test-interface-1
+    speed: 10
+    duplex: full
+    mtu: 256
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/2 description test-interface-1" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 speed 10" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 duplex full" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 mtu 256" in result.commands'
+
+- name: Delete interface parameters
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/2 description configured by iosxr_interface" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/2 speed 10" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/2 duplex full" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/2 mtu 256" in result.commands'
+
+- name: Delete interface parameters (idempotent)
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == false'
+
+- name: Disable interface
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    state: down
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/2 shutdown" in result.commands'
+
+- name: Enable interface
+  net_interface:
+    name: GigabitEthernet0/0/0/2
+    state: up
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"no interface GigabitEthernet0/0/0/2 shutdown" in result.commands'
+
+- name: Confgure second interface (setup)
+  net_interface:
+    name: GigabitEthernet0/0/0/3
+    description: test-interface-initial
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/3 description test-interface-initial" in result.commands'
+
+- name: Add interface aggregate
+  net_interface:
+    aggregate:
+    - { name: GigabitEthernet0/0/0/3, speed: 10, duplex: half, mtu: 256, description: test-interface-1 }
+    - { name: GigabitEthernet0/0/0/2, speed: 100, duplex: full, mtu: 516, description: test-interface-2 }
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/3 speed 10" in result.commands'
+      - '"interface GigabitEthernet0/0/0/3 description test-interface-1" in result.commands'
+      - '"interface GigabitEthernet0/0/0/3 duplex half" in result.commands'
+      - '"interface GigabitEthernet0/0/0/3 mtu 256" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 speed 100" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 description test-interface-2" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 duplex full" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 mtu 516" in result.commands'
+
+- name: Add interface aggregate (idempotent)
+  net_interface:
+    aggregate:
+    - { name: GigabitEthernet0/0/0/3, speed: 10, duplex: half, mtu: 256, description: test-interface-1 }
+    - { name: GigabitEthernet0/0/0/2, speed: 100, duplex: full, mtu: 516, description: test-interface-2 }
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == false'
+
+
+- name: Change interface parameters in aggregate
+  net_interface:
+    aggregate:
+    - { name: GigabitEthernet0/0/0/3 }
+    - { name: GigabitEthernet0/0/0/2 }
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"no interface GigabitEthernet0/0/0/3 speed 10" in result.commands'
+      - '"interface GigabitEthernet0/0/0/3 description configured by iosxr_interface" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/3 duplex half" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/3 mtu 256" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/2 speed 100" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 description configured by iosxr_interface" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/2 duplex full" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/2 mtu 516" in result.commands'
+
+- name: Disable interface aggregate
+  net_interface:
+    aggregate:
+    - { name: GigabitEthernet0/0/0/3, state: down }
+    - { name: GigabitEthernet0/0/0/2, state: down }
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/3 shutdown" in result.commands'
+      - '"interface GigabitEthernet0/0/0/2 shutdown" in result.commands'
+
+- name: Enable interface aggregate
+  net_interface:
+    aggregate:
+    - { name: GigabitEthernet0/0/0/3, state: up }
+    - { name: GigabitEthernet0/0/0/2, state: up }
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"no interface GigabitEthernet0/0/0/3 shutdown" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/2 shutdown" in result.commands'
+
+- name: Create interface aggregate
+  net_interface:
+    aggregate:
+    - { name: GigabitEthernet0/0/0/4 }
+    - { name: GigabitEthernet0/0/0/5 }
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"interface GigabitEthernet0/0/0/4 description configured by iosxr_interface" in result.commands'
+      - '"interface GigabitEthernet0/0/0/5 description configured by iosxr_interface" in result.commands'
+
+- name: Delete interface aggregate
+  net_interface:
+    aggregate:
+    - { name: GigabitEthernet0/0/0/4, state: absent }
+    - { name: GigabitEthernet0/0/0/5, state: absent }
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"no interface GigabitEthernet0/0/0/4" in result.commands'
+      - '"no interface GigabitEthernet0/0/0/5" in result.commands'
+
+- name: Delete interface aggregate (idempotent)
+  net_interface:
+    aggregate:
+    - { name: GigabitEthernet0/0/0/4, state: absent }
+    - { name: GigabitEthernet0/0/0/5, state: absent }
+    state: present
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == false'
+
+- debug: msg="END net_interface iosxr/basic.yaml"