internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-07 05:42:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Verify SHA in Shippable change detection.

Browse Source
This commit is contained in:
Matt Clay
2017-03-15 11:10:50 -07:00
parent 273786d0bd
commit 5e9a2b8528
2 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/runner/lib/changes.py
View File

@@ -71,7 +71,7 @@ class ShippableChanges(object):
self.paths = sorted(git.get_diff_names([self.branch]))
else:
merge_runs = self.get_merge_runs(self.project_id, self.branch)
last_successful_commit = self.get_last_successful_commit(merge_runs)
last_successful_commit = self.get_last_successful_commit(git, merge_runs)
if last_successful_commit:
self.paths = sorted(git.get_diff_names([last_successful_commit, self.commit]))
@@ -96,8 +96,9 @@ class ShippableChanges(object):
return response.json()
@staticmethod
def get_last_successful_commit(merge_runs):
def get_last_successful_commit(git, merge_runs):
"""
:type git: Git
:type merge_runs: dict | list[dict]
:rtype: str
"""
@@ -114,7 +115,8 @@ class ShippableChanges(object):
if commit_sha not in known_commits:
known_commits.add(commit_sha)
if merge_run['statusCode'] == 30:
last_successful_commit = commit_sha
if git.is_valid_ref(commit_sha):
last_successful_commit = commit_sha
return last_successful_commit