internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-07 22:02:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cmp python3 compat (#25008)

Browse Source 
* Use double-quotes for expect integration tests

* Cast user input to string for expect integration tests

* Remove usage of cmp() for python3 compatibility

- Add code smell test to look for cmp usage

- Fixes #24756
This commit is contained in:
kkjang
2017-05-24 15:59:59 -07:00
committed by Toshio Kuratomi
parent 64f63a3cac
commit 5c43bd3bae
5 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/ansible/modules/network/cloudengine/ce_rollback.py
View File

@@ -402,7 +402,7 @@ class RollBack(object):
self.module.fail_json(
msg='Error: Commit label which should not start with a number.')
if len(self.label.replace(' ', '')) == 1:
if cmp(self.label, '-') == 0:
if self.label == '-':
self.module.fail_json(
msg='Error: Commit label which should not be "-"')
if len(self.label.replace(' ', '')) < 1 or len(self.label) > 256: