internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-07 05:42:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

pkgng: check_mode should count queued actions

Browse Source 
Writing tests caught a bug in PR #3393, which enabled
installing more than one package per `pkg` execution.

In converting the module's install/upgrade code to a
queue structure, check_mode got broken because the count
of actions performed was only updated in the `if not check_mode`
block that invokes `pkg`. This two-line change counts
the number of actions in the queue when check mode is
enabled.
This commit is contained in:
Ross Williams
2021-10-08 19:29:36 +00:00
parent 4fe3aea3a9
commit 5aff694dc4
2 changed files with 29 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
changelogs/fragments/3526-pkgng-add-integration-tests.yml
View File

@@ -1,2 +1,3 @@
bugfixes:
- 'pkgng - `name=* state=latest` check for upgrades did not count "Number of packages to be reinstalled" as a `changed` action, giving incorrect results in both regular and check mode'
- 'pkgng - PR #3393 (https://github.com/ansible-collections/community.general/pull/3393) broke `check_mode` so that the module always reports `not changed`; fix regression so module reports number of upgrade or install actions that would be performed'