internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-07 22:02:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Parse multiple values for single key in cmdline facts (#49591)

Browse Source 
* Facts parsing for cmdline can now handle multiple values for a single key.
* Unit tests for cmdline fact parsing
* Review comments

Fixes: #22766

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
This commit is contained in:
Abhijeet Kasurde
2019-02-19 15:47:06 +05:30
committed by GitHub
parent e98d1b1be5
commit 57d85031d7
4 changed files with 98 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
lib/ansible/module_utils/facts/system/cmdline.py
View File

@@ -44,6 +44,27 @@ class CmdLineFactCollector(BaseFactCollector):
return cmdline_dict
def _parse_proc_cmdline_facts(self, data):
cmdline_dict = {}
try:
for piece in shlex.split(data, posix=False):
item = piece.split('=', 1)
if len(item) == 1:
cmdline_dict[item[0]] = True
else:
if item[0] in cmdline_dict:
if isinstance(cmdline_dict[item[0]], list):
cmdline_dict[item[0]].append(item[1])
else:
new_list = [cmdline_dict[item[0]], item[1]]
cmdline_dict[item[0]] = new_list
else:
cmdline_dict[item[0]] = item[1]
except ValueError:
pass
return cmdline_dict
def collect(self, module=None, collected_facts=None):
cmdline_facts = {}
@@ -53,4 +74,6 @@ class CmdLineFactCollector(BaseFactCollector):
return cmdline_facts
cmdline_facts['cmdline'] = self._parse_proc_cmdline(data)
cmdline_facts['proc_cmdline'] = self._parse_proc_cmdline_facts(data)
return cmdline_facts