internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-08 06:12:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix failing aws_ses_identity integration tests (#39560)

Browse Source 
* Fix failing aws_ses_identity integration tests

Reduce boilerplate with yaml anchor

* remove unstable test alias

* Update feedback forwarding check to use desired state rather than
repeated API calls.
This commit is contained in:
Sloane Hertel
2018-05-17 13:45:02 -04:00
committed by GitHub
parent 40146f33f9
commit 571c183f59
3 changed files with 122 additions and 124 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
test/integration/targets/aws_ses_identity/aliases
View File

@@ -1,3 +1,2 @@
cloud/aws
posix/ci/cloud/group4/aws
unstable

226
test/integration/targets/aws_ses_identity/tasks/main.yaml
View File

@@ -1,15 +1,21 @@
---
# ============================================================
- name: set up aws connection info
set_fact:
aws_connection_info: &aws_connection_info
aws_access_key: "{{ aws_access_key }}"
aws_secret_key: "{{ aws_secret_key }}"
security_token: "{{ security_token }}"
region: "{{ aws_region }}"
no_log: yes
- name: test register email identity
block:
- name: register email identity
aws_ses_identity:
identity: "{{ email_identity }}"
state: present
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
register: result
- name: assert changed is True
assert:
@@ -23,10 +29,7 @@
aws_ses_identity:
identity: "{{ email_identity }}"
state: absent
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
# ============================================================
- name: test register domain identity
block:
@@ -34,10 +37,7 @@
aws_ses_identity:
identity: "{{ domain_identity }}"
state: present
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
register: result
- name: assert changed is True
assert:
@@ -55,10 +55,7 @@
aws_ses_identity:
identity: "{{ domain_identity }}"
state: absent
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
# ============================================================
- name: test email_identity unchanged when already existing
block:
@@ -66,18 +63,12 @@
aws_ses_identity:
identity: "{{ email_identity }}"
state: present
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
- name: duplicate register identity
aws_ses_identity:
identity: "{{ email_identity }}"
state: present
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
register: result
- name: assert changed is False
assert:
@@ -91,10 +82,7 @@
aws_ses_identity:
identity: "{{ email_identity }}"
state: absent
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
# ============================================================
- name: test domain_identity unchanged when already existing
block:
@@ -102,18 +90,12 @@
aws_ses_identity:
identity: "{{ domain_identity }}"
state: present
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
- name: duplicate register identity
aws_ses_identity:
identity: "{{ domain_identity }}"
state: present
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
register: result
- name: assert changed is False
assert:
@@ -127,19 +109,13 @@
aws_ses_identity:
identity: "{{ domain_identity }}"
state: absent
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
# ============================================================
- name: remove non-existent email identity
aws_ses_identity:
identity: "{{ email_identity }}"
state: absent
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
register: result
- name: assert changed is False
assert:
@@ -150,10 +126,7 @@
aws_ses_identity:
identity: "{{ domain_identity }}"
state: absent
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
register: result
- name: assert changed is False
assert:
@@ -166,10 +139,7 @@
sns_topic:
name: "{{ notification_queue_name }}-{{ item }}"
state: present
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
register: topic_info
with_items:
- bounce
@@ -185,10 +155,7 @@
topic: "{{ topic_info.results[1].sns_arn }}"
delivery_notifications:
topic: "{{ topic_info.results[2].sns_arn }}"
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
register: result
- name: assert notification settings
assert:
@@ -207,10 +174,7 @@
sns_topic:
name: "{{ notification_queue_name }}-{{ item }}"
state: absent
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
with_items:
- bounce
- complaint
@@ -219,10 +183,7 @@
aws_ses_identity:
identity: "{{ email_identity }}"
state: absent
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
# ============================================================
- name: test change notification queues after create
block:
@@ -230,10 +191,7 @@
sns_topic:
name: "{{ notification_queue_name }}-{{ item }}"
state: present
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
register: topic_info
with_items:
- bounce
@@ -243,10 +201,7 @@
aws_ses_identity:
identity: "{{ email_identity }}"
state: present
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
- name: set notification topics
aws_ses_identity:
identity: "{{ email_identity }}"
@@ -257,10 +212,7 @@
topic: "{{ topic_info.results[1].sns_arn }}"
delivery_notifications:
topic: "{{ topic_info.results[2].sns_arn }}"
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
register: result
- name: assert changed is True
assert:
@@ -277,10 +229,7 @@
sns_topic:
name: "{{ notification_queue_name }}-{{ item }}"
state: absent
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
with_items:
- bounce
- complaint
@@ -289,10 +238,7 @@
aws_ses_identity:
identity: "{{ email_identity }}"
state: absent
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
# ============================================================
- name: test include headers on notification queues
block:
@@ -306,10 +252,7 @@
include_headers: Yes
delivery_notifications:
include_headers: Yes
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
register: result
- name: assert notification headers enabled
assert:
@@ -322,10 +265,7 @@
aws_ses_identity:
identity: "{{ email_identity }}"
state: absent
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
# ============================================================
- name: test disable feedback forwarding
block:
@@ -333,10 +273,7 @@
sns_topic:
name: "{{ notification_queue_name }}-{{ item }}"
state: present
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
register: topic_info
with_items:
- bounce
@@ -350,10 +287,7 @@
complaint_notifications:
topic: "{{ topic_info.results[1].sns_arn }}"
feedback_forwarding: No
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
register: result
- name: assert feedback_forwarding == False
assert:
@@ -364,10 +298,7 @@
sns_topic:
name: "{{ notification_queue_name }}-{{ item }}"
state: absent
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
with_items:
- bounce
- complaint
@@ -375,10 +306,7 @@
aws_ses_identity:
identity: "{{ email_identity }}"
state: absent
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
# ============================================================
- name: test disable feedback forwarding fails if no topics
block:
@@ -387,22 +315,84 @@
identity: "{{ domain_identity }}"
state: present
feedback_forwarding: No
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
register: result
failed_when: result.failed == False
- name: assert error.code == InvalidParameterValue
- name: assert error message starts with "Invalid Parameter Value"
assert:
that:
- result.error.code == 'InvalidParameterValue'
- '"Invalid Parameter Value" in result.msg'
always:
- name: cleanup identity
aws_ses_identity:
identity: "{{ domain_identity }}"
state: absent
region: "{{ ec2_region }}"
aws_access_key: "{{ ec2_access_key }}"
aws_secret_key: "{{ ec2_secret_key }}"
security_token: "{{security_token}}"
<<: *aws_connection_info
# ============================================================
- name: test disable feedback forwarding fails if no complaint topic
block:
- name: test topic
sns_topic:
name: "{{ notification_queue_name }}-bounce"
state: present
<<: *aws_connection_info
register: topic_info
- name: register email identity
aws_ses_identity:
identity: "{{ email_identity }}"
state: present
bounce_notifications:
topic: "{{ topic_info.sns_arn }}"
feedback_forwarding: No
<<: *aws_connection_info
register: result
failed_when: result.failed == False
- name: assert error message starts with "Invalid Parameter Value"
assert:
that:
- '"Invalid Parameter Value" in result.msg'
always:
- name: cleanup topics
sns_topic:
name: "{{ notification_queue_name }}-bounce"
state: absent
<<: *aws_connection_info
- name: cleanup identity
aws_ses_identity:
identity: "{{ email_identity }}"
state: absent
<<: *aws_connection_info
# ============================================================
- name: test disable feedback forwarding fails if no bounce topic
block:
- name: test topic
sns_topic:
name: "{{ notification_queue_name }}-complaint"
state: present
<<: *aws_connection_info
register: topic_info
- name: register email identity
aws_ses_identity:
identity: "{{ email_identity }}"
state: present
complaint_notifications:
topic: "{{ topic_info.sns_arn }}"
feedback_forwarding: No
<<: *aws_connection_info
register: result
failed_when: result.failed == False
- name: assert error message starts with "Invalid Parameter Value"
assert:
that:
- '"Invalid Parameter Value" in result.msg'
always:
- name: cleanup topics
sns_topic:
name: "{{ notification_queue_name }}-complaint"
state: absent
<<: *aws_connection_info
- name: cleanup identity
aws_ses_identity:
identity: "{{ email_identity }}"
state: absent
<<: *aws_connection_info