Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc
This commit is contained in:
Matt Martz
2017-11-27 16:58:08 -06:00
committed by ansibot
parent fd4a6cf7ad
commit 4fe08441be
349 changed files with 4086 additions and 3844 deletions

View File

@@ -16,7 +16,7 @@
- name: assert install local exe (check mode)
assert:
that:
- install_local_exe_check|changed
- install_local_exe_check is changed
- install_local_exe_check.reboot_required == False
- install_local_exe_actual_check.exists == False
@@ -36,7 +36,7 @@
- name: assert install local exe
assert:
that:
- install_local_exe|changed
- install_local_exe is changed
- install_local_exe.reboot_required == False
- install_local_exe.rc == 0
- install_local_exe_actual.exists == True
@@ -52,7 +52,7 @@
- name: assert install local exe (idempotent)
assert:
that:
- not install_local_exe_idempotent|changed
- install_local_exe_idempotent is not changed
- name: uninstall local exe with path (check mode)
win_package:
@@ -71,7 +71,7 @@
- name: assert uninstall local exe with path (check mode)
assert:
that:
- uninstall_path_local_exe_check|changed
- uninstall_path_local_exe_check is changed
- uninstall_path_local_exe_check.reboot_required == False
- uninstall_path_local_exe_actual_check.exists == True
@@ -91,7 +91,7 @@
- name: assert uninstall local exe with path
assert:
that:
- uninstall_path_local_exe|changed
- uninstall_path_local_exe is changed
- uninstall_path_local_exe.reboot_required == False
- uninstall_path_local_exe.rc == 0
- uninstall_path_local_exe_actual.exists == False
@@ -107,7 +107,7 @@
- name: assert uninstall local exe with path (idempotent)
assert:
that:
- not uninstall_path_local_exe_idempotent|changed
- uninstall_path_local_exe_idempotent is not changed
- name: install url exe (check mode)
win_package:
@@ -126,7 +126,7 @@
- name: assert install url exe (check mode)
assert:
that:
- install_url_exe_check|changed
- install_url_exe_check is changed
- install_url_exe_check.reboot_required == False
- install_url_exe_actual_check.exists == False
@@ -146,7 +146,7 @@
- name: assert install url exe
assert:
that:
- install_url_exe|changed
- install_url_exe is changed
- install_url_exe.reboot_required == False
- install_url_exe.rc == 0
- install_url_exe_actual.exists == True
@@ -162,7 +162,7 @@
- name: assert install url exe (idempotent)
assert:
that:
- not install_url_exe_again|changed
- install_url_exe_again is not changed
- name: uninstall local exe with product_id (check mode)
win_package:
@@ -180,7 +180,7 @@
- name: assert uninstall local exe with product_id (check mode)
assert:
that:
- uninstall_id_local_exe_check|changed
- uninstall_id_local_exe_check is changed
- uninstall_id_local_exe_check.reboot_required == False
- uninstall_id_local_exe_actual_check.exists == True
@@ -199,7 +199,7 @@
- name: assert uninstall local exe with product_id
assert:
that:
- uninstall_id_local_exe|changed
- uninstall_id_local_exe is changed
- uninstall_id_local_exe.reboot_required == False
- uninstall_id_local_exe.rc == 0
- uninstall_id_local_exe_actual.exists == False
@@ -214,7 +214,7 @@
- name: assert uninstall local exe with product_id (idempotent)
assert:
that:
- not uninstall_id_local_exe_idempotent|changed
- uninstall_id_local_exe_idempotent is not changed
- name: install exe checking path
win_package:
@@ -257,7 +257,7 @@
- name: assert install exe checking path and version
assert:
that:
- not install_exe_create_version_match|changed
- install_exe_create_version_match is not changed
- name: install exe checking path and version mismatch
win_package:
@@ -270,7 +270,7 @@
- name: assert install exe checking path and version mistmatch
assert:
that:
- install_exe_create_version_mismatch|changed
- install_exe_create_version_mismatch is changed
- name: install exe checking service
win_package:
@@ -282,7 +282,7 @@
- name: assert install exe checking service
assert:
that:
- not install_exe_create_service_match|changed
- install_exe_create_service_match is not changed
- name: install exe checking service mismatch
win_package:
@@ -294,7 +294,7 @@
- name: assert install exe checking service mismatch
assert:
that:
- install_exe_create_service_mismatch|changed
- install_exe_create_service_mismatch is changed
- name: uninstall exe post tests
win_package:

View File

@@ -21,7 +21,7 @@
- name: assert install local msi (check mode)
assert:
that:
- install_local_msi_check|changed
- install_local_msi_check is changed
- install_local_msi_check.reboot_required == False
- install_local_msi_actual_check.exists == False
@@ -40,7 +40,7 @@
- name: assert install local msi
assert:
that:
- install_local_msi|changed
- install_local_msi is changed
- install_local_msi.reboot_required == False
- install_local_msi.rc == 0
- install_local_msi_actual.exists == True
@@ -54,7 +54,7 @@
- name: assert install local msi (idempotent)
assert:
that:
- not install_local_msi_idempotent|changed
- install_local_msi_idempotent is not changed
- name: uninstall local msi with path (check mode)
win_package:
@@ -71,7 +71,7 @@
- name: assert uninstall local msi with path (check mode)
assert:
that:
- uninstall_path_local_msi_check|changed
- uninstall_path_local_msi_check is changed
- uninstall_path_local_msi_check.reboot_required == False
- uninstall_path_local_msi_actual_check.exists == True
@@ -89,7 +89,7 @@
- name: assert uninstall local msi with path
assert:
that:
- uninstall_path_local_msi|changed
- uninstall_path_local_msi is changed
- uninstall_path_local_msi.reboot_required == False
- uninstall_path_local_msi.rc == 0
- uninstall_path_local_msi_actual.exists == False
@@ -103,7 +103,7 @@
- name: assert uninstall local msi with path (idempotent)
assert:
that:
- not uninstall_path_local_msi_idempotent|changed
- uninstall_path_local_msi_idempotent is not changed
- name: install url msi (check mode)
win_package:
@@ -121,7 +121,7 @@
- name: assert install url msi (check mode)
assert:
that:
- install_url_msi_check|changed
- install_url_msi_check is changed
- install_url_msi_check.reboot_required == False
- install_url_msi_actual_check.exists == False
@@ -140,7 +140,7 @@
- name: assert install url msi
assert:
that:
- install_url_msi|changed
- install_url_msi is changed
- install_url_msi.reboot_required == False
- install_url_msi.rc == 0
- install_url_msi_actual.exists == True
@@ -155,7 +155,7 @@
- name: assert install url msi (idempotent)
assert:
that:
- not install_url_msi_again|changed
- install_url_msi_again is not changed
- name: uninstall local msi with product_id (check mode)
win_package:
@@ -172,7 +172,7 @@
- name: assert uninstall local msi with product_id (check mode)
assert:
that:
- uninstall_id_local_msi_check|changed
- uninstall_id_local_msi_check is changed
- uninstall_id_local_msi_check.reboot_required == False
- uninstall_id_local_msi_actual_check.exists == True
@@ -190,7 +190,7 @@
- name: assert uninstall local msi with product_id
assert:
that:
- uninstall_id_local_msi|changed
- uninstall_id_local_msi is changed
- uninstall_id_local_msi.reboot_required == False
- uninstall_id_local_msi.rc == 0
- uninstall_id_local_msi_actual.exists == False
@@ -204,7 +204,7 @@
- name: assert uninstall local msi with product_id (idempotent)
assert:
that:
- not uninstall_id_local_msi_idempotent|changed
- uninstall_id_local_msi_idempotent is not changed
- name: install local reboot msi (check mode)
win_package:
@@ -221,7 +221,7 @@
- name: assert install local reboot msi (check mode)
assert:
that:
- install_local_reboot_msi_check|changed
- install_local_reboot_msi_check is changed
- install_local_reboot_msi_check.reboot_required == False
- install_local_reboot_msi_actual_check.exists == False
@@ -239,7 +239,7 @@
- name: assert install local reboot msi
assert:
that:
- install_local_reboot_msi|changed
- install_local_reboot_msi is changed
- install_local_reboot_msi.reboot_required == True
- install_local_reboot_msi.rc == 3010
- install_local_reboot_msi_actual.exists == True
@@ -253,7 +253,7 @@
- name: assert install local reboot msi (idempotent)
assert:
that:
- not install_local_reboot_msi_idempotent|changed
- install_local_reboot_msi_idempotent is not changed
- name: uninstall reboot msi after test
win_package:
@@ -286,7 +286,7 @@
- name: assert install local msi with arguments (check mode)
assert:
that:
- install_msi_argument_check|changed
- install_msi_argument_check is changed
- install_msi_argument_check.reboot_required == False
- install_msi_argument_moo_check.stat.exists == False
- install_msi_argument_cow_check.stat.exists == False
@@ -311,7 +311,7 @@
- name: assert install local msi with arguments
assert:
that:
- install_msi_argument|changed
- install_msi_argument is changed
- install_msi_argument.reboot_required == False
- install_msi_argument.rc == 0
- install_msi_argument_moo.stat.exists == False
@@ -327,7 +327,7 @@
- name: assert install local msi with arguments (idempotent)
assert:
that:
- not install_msi_argument_again|changed
- install_msi_argument_again is not changed
- name: uninstall good msi after test
win_package:
@@ -359,7 +359,7 @@
- name: assert results of install msi to custom path using string arguments
assert:
that:
- install_msi_string_arguments|changed
- install_msi_string_arguments is changed
- install_msi_string_arguments.reboot_required == False
- install_msi_string_arguments.rc == 0
- install_msi_string_arguments_moo.stat.exists == False
@@ -392,7 +392,7 @@
- name: assert results of install msi to custom path using list arguments
assert:
that:
- install_msi_list_arguments|changed
- install_msi_list_arguments is changed
- install_msi_list_arguments.reboot_required == False
- install_msi_list_arguments.rc == 0
- install_msi_list_arguments_moo.stat.exists == True

View File

@@ -17,7 +17,7 @@
- name: assert install network msi (check mode)
assert:
that:
- install_network_msi_check|changed
- install_network_msi_check is changed
- install_network_msi_check.reboot_required == False
- install_network_msi_actual_check.exists == False
@@ -38,7 +38,7 @@
- name: assert install network msi
assert:
that:
- install_network_msi|changed
- install_network_msi is changed
- install_network_msi.reboot_required == False
- install_network_msi.rc == 0
- install_network_msi_actual.exists == True
@@ -55,7 +55,7 @@
- name: assert install network msi (idempotent)
assert:
that:
- not install_network_msi_idempotent|changed
- install_network_msi_idempotent is not changed
- name: uninstall network msi with path (check mode)
win_package:
@@ -75,7 +75,7 @@
- name: assert uninstall network msi with path (check mode)
assert:
that:
- uninstall_path_network_msi_check|changed
- uninstall_path_network_msi_check is changed
- uninstall_path_network_msi_check.reboot_required == False
- uninstall_path_network_msi_actual_check.exists == True
@@ -96,7 +96,7 @@
- name: assert uninstall network msi with path
assert:
that:
- uninstall_path_network_msi|changed
- uninstall_path_network_msi is changed
- uninstall_path_network_msi.reboot_required == False
- uninstall_path_network_msi.rc == 0
- uninstall_path_network_msi_actual.exists == False
@@ -113,7 +113,7 @@
- name: assert uninstall network msi with path (idempotent)
assert:
that:
- not uninstall_path_network_msi_idempotent|changed
- uninstall_path_network_msi_idempotent is not changed
- name: install network reboot msi (check mode)
win_package:
@@ -133,7 +133,7 @@
- name: assert install network reboot msi (check mode)
assert:
that:
- install_network_reboot_msi_check|changed
- install_network_reboot_msi_check is changed
- install_network_reboot_msi_check.reboot_required == False
- install_network_reboot_msi_actual_check.exists == False
@@ -154,7 +154,7 @@
- name: assert install network reboot msi
assert:
that:
- install_network_reboot_msi|changed
- install_network_reboot_msi is changed
- install_network_reboot_msi.reboot_required == True
- install_network_reboot_msi.rc == 3010
- install_network_reboot_msi_actual.exists == True
@@ -171,7 +171,7 @@
- name: assert install network reboot msi (idempotent)
assert:
that:
- not install_network_reboot_msi_idempotent|changed
- install_network_reboot_msi_idempotent is not changed
- name: uninstall network msi with product_id (check mode)
win_package:
@@ -190,7 +190,7 @@
- name: assert uninstall network msi with product_id (check mode)
assert:
that:
- uninstall_id_network_msi_check|changed
- uninstall_id_network_msi_check is changed
- uninstall_id_network_msi_check.reboot_required == False
- uninstall_id_network_msi_actual_check.exists == True
@@ -208,7 +208,7 @@
- name: assert uninstall network msi with product_id
assert:
that:
- uninstall_id_network_msi|changed
- uninstall_id_network_msi is changed
- uninstall_id_network_msi.reboot_required == True
- uninstall_id_network_msi.rc == 3010
- uninstall_id_network_msi_actual.exists == False
@@ -222,7 +222,7 @@
- name: assert uninstall network msi with product_id (idempotent)
assert:
that:
- not uninstall_id_network_msi_idempotent|changed
- uninstall_id_network_msi_idempotent is not changed
- name: ensure the install folder is cleaned in case uninstall didn't work
win_file:
@@ -253,7 +253,7 @@
- name: assert install network msi with arguments (check mode)
assert:
that:
- install_network_msi_argument_check|changed
- install_network_msi_argument_check is changed
- install_network_msi_argument_check.reboot_required == False
- install_network_msi_argument_moo_check.stat.exists == False
- install_network_msi_argument_cow_check.stat.exists == False
@@ -281,7 +281,7 @@
- name: assert install network msi with arguments
assert:
that:
- install_network_msi_argument|changed
- install_network_msi_argument is changed
- install_network_msi_argument.reboot_required == False
- install_network_msi_argument.rc == 0
- install_network_msi_argument_moo.stat.exists == False
@@ -300,7 +300,7 @@
- name: assert install network msi with arguments (idempotent)
assert:
that:
- not install_network_msi_argument_again|changed
- install_network_msi_argument_again is not changed
- name: uninstall msi after test
win_package:
@@ -326,7 +326,7 @@
- name: assert install network exe (check mode)
assert:
that:
- install_network_exe_check|changed
- install_network_exe_check is changed
- install_network_exe_check.reboot_required == False
- install_network_exe_actual_check.exists == False
@@ -348,7 +348,7 @@
- name: assert install network exe
assert:
that:
- install_network_exe|changed
- install_network_exe is changed
- install_network_exe.reboot_required == False
- install_network_exe.rc == 0
- install_network_exe_actual.exists == True
@@ -366,7 +366,7 @@
- name: assert install network exe (idempotent)
assert:
that:
- not install_network_exe_idempotent|changed
- install_network_exe_idempotent is not changed
- name: uninstall network exe (check mode)
win_package:
@@ -386,7 +386,7 @@
- name: assert uninstall network exe (check mode)
assert:
that:
- uninstall_network_exe_check|changed
- uninstall_network_exe_check is changed
- uninstall_network_exe_check.reboot_required == False
- uninstall_network_exe_actual_check.exists == True
@@ -407,7 +407,7 @@
- name: assert uninstall network exe
assert:
that:
- uninstall_network_exe|changed
- uninstall_network_exe is changed
- uninstall_network_exe.reboot_required == False
- uninstall_network_exe.rc == 0
- uninstall_network_exe_actual.exists == False
@@ -424,4 +424,4 @@
- name: assert uninstall network exe (idempotent)
assert:
that:
- not uninstall_network_exe_idempotent|changed
- uninstall_network_exe_idempotent is not changed