mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-05-08 22:33:25 +00:00
Deprecate tests used as filters (#32361)
* Warn on tests used as filters * Update docs, add aliases for tests that fit more gramatically with test syntax * Fix rst formatting * Add successful filter, alias of success * Remove renamed_deprecation, it was overkill * Make directory alias for is_dir * Update tests to use proper jinja test syntax * Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax * Add conversion script, porting guide updates, and changelog updates * Update newly added uses of tests as filters * No underscore variable * Convert recent tests as filter changes to win_stat * Fix some changes related to rebasing a few integration tests * Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name * Add test for tests_as_filters_warning * Update tests as filters in newly added/modified tests * Address recent changes to several integration tests * Address recent changes in cs_vpc
This commit is contained in:
@@ -26,7 +26,7 @@
|
||||
win_feature:
|
||||
name: "{{ test_win_feature_name }}"
|
||||
state: absent
|
||||
when: win_feature_has_servermanager|success
|
||||
when: win_feature_has_servermanager is successful
|
||||
|
||||
- name: install feature
|
||||
win_feature:
|
||||
@@ -36,12 +36,12 @@
|
||||
include_sub_features: yes
|
||||
include_management_tools: yes
|
||||
register: win_feature_install_result
|
||||
when: win_feature_has_servermanager|success
|
||||
when: win_feature_has_servermanager is successful
|
||||
|
||||
- name: check result of installing feature
|
||||
assert:
|
||||
that:
|
||||
- "win_feature_install_result|changed"
|
||||
- "win_feature_install_result is changed"
|
||||
- "win_feature_install_result.success"
|
||||
- "win_feature_install_result.exitcode == 'Success'"
|
||||
- "not win_feature_install_result.restart_needed"
|
||||
@@ -52,7 +52,7 @@
|
||||
- "win_feature_install_result.feature_result[0].restart_needed is defined"
|
||||
- "win_feature_install_result.feature_result[0].skip_reason"
|
||||
- "win_feature_install_result.feature_result[0].success is defined"
|
||||
when: win_feature_has_servermanager|success
|
||||
when: win_feature_has_servermanager is successful
|
||||
|
||||
- name: install feature again
|
||||
win_feature:
|
||||
@@ -62,29 +62,29 @@
|
||||
include_sub_features: yes
|
||||
include_management_tools: yes
|
||||
register: win_feature_install_again_result
|
||||
when: win_feature_has_servermanager|success
|
||||
when: win_feature_has_servermanager is successful
|
||||
|
||||
- name: check result of installing feature again
|
||||
assert:
|
||||
that:
|
||||
- "not win_feature_install_again_result|changed"
|
||||
- "win_feature_install_again_result is not changed"
|
||||
- "win_feature_install_again_result.success"
|
||||
- "win_feature_install_again_result.exitcode == 'NoChangeNeeded'"
|
||||
- "not win_feature_install_again_result.restart_needed"
|
||||
- "win_feature_install_again_result.feature_result == []"
|
||||
when: win_feature_has_servermanager|success
|
||||
when: win_feature_has_servermanager is successful
|
||||
|
||||
- name: remove feature
|
||||
win_feature:
|
||||
name: "{{ test_win_feature_name }}"
|
||||
state: absent
|
||||
register: win_feature_remove_result
|
||||
when: win_feature_has_servermanager|success
|
||||
when: win_feature_has_servermanager is successful
|
||||
|
||||
- name: check result of removing feature
|
||||
assert:
|
||||
that:
|
||||
- "win_feature_remove_result|changed"
|
||||
- "win_feature_remove_result is changed"
|
||||
- "win_feature_remove_result.success"
|
||||
- "win_feature_remove_result.exitcode == 'Success'"
|
||||
- "not win_feature_remove_result.restart_needed"
|
||||
@@ -95,24 +95,24 @@
|
||||
- "win_feature_remove_result.feature_result[0].restart_needed is defined"
|
||||
- "win_feature_remove_result.feature_result[0].skip_reason"
|
||||
- "win_feature_remove_result.feature_result[0].success is defined"
|
||||
when: win_feature_has_servermanager|success
|
||||
when: win_feature_has_servermanager is successful
|
||||
|
||||
- name: remove feature again
|
||||
win_feature:
|
||||
name: "{{ test_win_feature_name }}"
|
||||
state: absent
|
||||
register: win_feature_remove_again_result
|
||||
when: win_feature_has_servermanager|success
|
||||
when: win_feature_has_servermanager is successful
|
||||
|
||||
- name: check result of removing feature again
|
||||
assert:
|
||||
that:
|
||||
- "not win_feature_remove_again_result|changed"
|
||||
- "win_feature_remove_again_result is not changed"
|
||||
- "win_feature_remove_again_result.success"
|
||||
- "win_feature_remove_again_result.exitcode == 'NoChangeNeeded'"
|
||||
- "not win_feature_remove_again_result.restart_needed"
|
||||
- "win_feature_remove_again_result.feature_result == []"
|
||||
when: win_feature_has_servermanager|success
|
||||
when: win_feature_has_servermanager is successful
|
||||
|
||||
- name: try to install an invalid feature name
|
||||
win_feature:
|
||||
@@ -120,16 +120,16 @@
|
||||
state: present
|
||||
register: win_feature_install_invalid_result
|
||||
ignore_errors: true
|
||||
when: win_feature_has_servermanager|success
|
||||
when: win_feature_has_servermanager is successful
|
||||
|
||||
- name: check result of installing invalid feature name
|
||||
assert:
|
||||
that:
|
||||
- "win_feature_install_invalid_result|failed"
|
||||
- "not win_feature_install_invalid_result|changed"
|
||||
- "win_feature_install_invalid_result is failed"
|
||||
- "win_feature_install_invalid_result is not changed"
|
||||
- "win_feature_install_invalid_result.msg"
|
||||
- "win_feature_install_invalid_result.exitcode == 'InvalidArgs'"
|
||||
when: win_feature_has_servermanager|success
|
||||
when: win_feature_has_servermanager is successful
|
||||
|
||||
- name: try to remove an invalid feature name
|
||||
win_feature:
|
||||
@@ -137,13 +137,13 @@
|
||||
state: absent
|
||||
register: win_feature_remove_invalid_result
|
||||
ignore_errors: true
|
||||
when: win_feature_has_servermanager|success
|
||||
when: win_feature_has_servermanager is successful
|
||||
|
||||
- name: check result of removing invalid feature name
|
||||
assert:
|
||||
that:
|
||||
- "win_feature_remove_invalid_result|failed"
|
||||
- "not win_feature_remove_invalid_result|changed"
|
||||
- "win_feature_remove_invalid_result is failed"
|
||||
- "win_feature_remove_invalid_result is not changed"
|
||||
- "win_feature_remove_invalid_result.msg"
|
||||
- "win_feature_remove_invalid_result.exitcode == 'InvalidArgs'"
|
||||
when: win_feature_has_servermanager|success
|
||||
when: win_feature_has_servermanager is successful
|
||||
|
||||
Reference in New Issue
Block a user