Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc
This commit is contained in:
Matt Martz
2017-11-27 16:58:08 -06:00
committed by ansibot
parent fd4a6cf7ad
commit 4fe08441be
349 changed files with 4086 additions and 3844 deletions

View File

@@ -10,7 +10,7 @@
- name: verify update instance ssh key non existent
assert:
that:
- instance|failed
- instance is failed
- 'instance.msg == "SSH key not found: {{ cs_resource_prefix }}-sshkey2"'
- name: test create instance without keypair in check mode
@@ -23,8 +23,8 @@
- name: verify create instance without keypair in check mode
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- name: test create instance without keypair
cs_instance:
@@ -35,8 +35,8 @@
- name: verify create instance without keypair
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- instance.ssh_key is not defined
- name: test create instance without keypair idempotence
@@ -48,8 +48,8 @@
- name: verify create instance without keypair idempotence
assert:
that:
- instance|success
- not instance|changed
- instance is successful
- instance is not changed
- instance.ssh_key is not defined
- name: setup ssh key2
@@ -58,7 +58,7 @@
- name: verify setup ssh key2
assert:
that:
- sshkey|success
- sshkey is successful
- name: test update instance ssh key2 in check mode
cs_instance:
@@ -70,7 +70,7 @@
- name: verify update instance ssh key2 in check mode
assert:
that:
- instance|changed
- instance is changed
- instance.ssh_key is not defined
- name: test update instance ssh key2
@@ -82,7 +82,7 @@
- name: verify update instance ssh key2
assert:
that:
- instance|changed
- instance is changed
- instance.ssh_key == "{{ cs_resource_prefix }}-sshkey2"
- name: test update instance ssh key2 idempotence
@@ -94,7 +94,7 @@
- name: verify update instance ssh key2 idempotence
assert:
that:
- not instance|changed
- instance is not changed
- instance.ssh_key == "{{ cs_resource_prefix }}-sshkey2"
- name: cleanup ssh key2
@@ -105,7 +105,7 @@
- name: verify cleanup ssh key2
assert:
that:
- sshkey2|success
- sshkey2 is successful
- name: test update instance ssh key2 idempotence2
cs_instance:
@@ -117,7 +117,7 @@
- name: verify update instance ssh key2 idempotence2
assert:
that:
- instance|failed
- instance is failed
- 'instance.msg == "SSH key not found: {{ cs_resource_prefix }}-sshkey2"'
- name: test update instance ssh key in check mode
@@ -130,7 +130,7 @@
- name: verify update instance ssh key in check mode
assert:
that:
- instance|changed
- instance is changed
- instance.ssh_key is not defined
- name: test update instance ssh key
@@ -142,7 +142,7 @@
- name: verify update instance ssh key
assert:
that:
- instance|changed
- instance is changed
- instance.ssh_key == "{{ cs_resource_prefix }}-sshkey"
- name: test update instance ssh key idempotence
@@ -154,7 +154,7 @@
- name: verify update instance ssh key idempotence
assert:
that:
- not instance|changed
- instance is not changed
- instance.ssh_key == "{{ cs_resource_prefix }}-sshkey"
- name: cleanup expunge instance
@@ -165,4 +165,4 @@
- name: verify cleanup expunge instance
assert:
that:
- instance|success
- instance is successful