Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc
This commit is contained in:
Matt Martz
2017-11-27 16:58:08 -06:00
committed by ansibot
parent fd4a6cf7ad
commit 4fe08441be
349 changed files with 4086 additions and 3844 deletions

View File

@@ -5,7 +5,7 @@
- name: verify instance to be absent
assert:
that:
- instance|success
- instance is successful
- name: test create instance in check mode
cs_instance:
@@ -21,8 +21,8 @@
- name: verify create instance in check mode
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- name: test create instance
cs_instance:
@@ -37,8 +37,8 @@
- name: verify create instance
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -59,8 +59,8 @@
- name: verify create instance idempotence
assert:
that:
- instance|success
- not instance|changed
- instance is successful
- instance is not changed
- instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -77,8 +77,8 @@
- name: verify running instance not updated in check mode
assert:
that:
- instance|success
- not instance|changed
- instance is successful
- instance is not changed
- instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -93,8 +93,8 @@
- name: verify running instance not updated
assert:
that:
- instance|success
- not instance|changed
- instance is successful
- instance is not changed
- instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -109,8 +109,8 @@
- name: verify stopping instance in check mode
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -124,8 +124,8 @@
- name: verify stopping instance
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -139,8 +139,8 @@
- name: verify stopping instance idempotence
assert:
that:
- instance|success
- not instance|changed
- instance is successful
- instance is not changed
- instance.state == "Stopped"
- name: test updating stopped instance in check mode
@@ -153,8 +153,8 @@
- name: verify updating stopped instance in check mode
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -169,8 +169,8 @@
- name: verify updating stopped instance
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
- instance.service_offering == "{{ test_cs_instance_offering_2 }}"
@@ -185,8 +185,8 @@
- name: verify updating stopped instance idempotence
assert:
that:
- instance|success
- not instance|changed
- instance is successful
- instance is not changed
- instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
- instance.service_offering == "{{ test_cs_instance_offering_2 }}"
@@ -201,8 +201,8 @@
- name: verify starting instance in check mode
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
- instance.service_offering == "{{ test_cs_instance_offering_2 }}"
@@ -216,8 +216,8 @@
- name: verify starting instance
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
- instance.service_offering == "{{ test_cs_instance_offering_2 }}"
@@ -231,8 +231,8 @@
- name: verify starting instance idempotence
assert:
that:
- instance|success
- not instance|changed
- instance is successful
- instance is not changed
- instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
- instance.service_offering == "{{ test_cs_instance_offering_2 }}"
@@ -248,8 +248,8 @@
- name: verify force update running instance in check mode
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
- instance.service_offering == "{{ test_cs_instance_offering_2 }}"
@@ -264,8 +264,8 @@
- name: verify force update running instance
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
- instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -280,8 +280,8 @@
- name: verify force update running instance idempotence
assert:
that:
- instance|success
- not instance|changed
- instance is successful
- instance is not changed
- instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
- instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -297,8 +297,8 @@
- name: verify restore instance in check mode
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
- instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -312,8 +312,8 @@
- name: verify restore instance
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
- instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
- instance.service_offering == "{{ test_cs_instance_offering_1 }}"