internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-07 22:02:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Deprecate tests used as filters (#32361)

Browse Source 
* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc
This commit is contained in:
Matt Martz
2017-11-27 16:58:08 -06:00
committed by ansibot
parent fd4a6cf7ad
commit 4fe08441be
349 changed files with 4086 additions and 3844 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/ansible/plugins/test/core.py
View File

@@ -30,7 +30,7 @@ from ansible import errors
def failed(result):
''' Test if task result yields failed '''
if not isinstance(result, MutableMapping):
raise errors.AnsibleFilterError("|failed expects a dictionary")
raise errors.AnsibleFilterError("The failed test expects a dictionary")
return result.get('failed', False)
@@ -42,7 +42,7 @@ def success(result):
def changed(result):
''' Test if task result yields changed '''
if not isinstance(result, MutableMapping):
raise errors.AnsibleFilterError("|changed expects a dictionary")
raise errors.AnsibleFilterError("The changed test expects a dictionary")
if 'changed' not in result:
changed = False
if (
@@ -62,7 +62,7 @@ def changed(result):
def skipped(result):
''' Test if task result yields skipped '''
if not isinstance(result, MutableMapping):
raise errors.AnsibleFilterError("|skipped expects a dictionary")
raise errors.AnsibleFilterError("The skipped test expects a dictionary")
return result.get('skipped', False)
@@ -129,6 +129,7 @@ class TestModule(object):
'failure': failed,
'succeeded': success,
'success': success,
'successful': success,
# changed testing
'changed': changed,
@@ -145,6 +146,7 @@ class TestModule(object):
# version comparison
'version_compare': version_compare,
'version': version_compare,
# lists
'any': any,