internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-07 13:52:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

FTD configuration module: fix a bug with response parsing (#57480)

Browse Source 
* Update dependence's name to firepower-kickstart

* Check response type before getting attributes

* Add unit test for construct_ansible_facts method

* Update error message
This commit is contained in:
Anton Nikulin
2019-06-10 16:00:36 +03:00
committed by Sumit Jaiswal
parent 039eb892ba
commit 4fa93d5b9b
5 changed files with 80 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/ansible/module_utils/network/ftd/common.py
View File

@@ -65,7 +65,7 @@ def construct_ansible_facts(response, params):
response_body = response['items'] if 'items' in response else response
if params.get('register_as'):
facts[params['register_as']] = response_body
elif response_body.get('name') and response_body.get('type'):
elif type(response_body) is dict and response_body.get('name') and response_body.get('type'):
object_name = re.sub(INVALID_IDENTIFIER_SYMBOLS, '_', response_body['name'].lower())
fact_name = '%s_%s' % (response_body['type'], object_name)
facts[fact_name] = response_body