Various cleanup to run_command

* Rename fail_on_rc_non_zero to check_rc, much more succinct.
* Simplify method defintion
* Fix command module and drop shell=shell option; whether to use
  shell is determined by if args is a list.
This commit is contained in:
Stephen Fromm
2013-01-13 09:12:40 -08:00
parent 4f110e4fc6
commit 4eaee3df0a
7 changed files with 18 additions and 24 deletions

View File

@@ -85,7 +85,7 @@ class Subversion(object):
if self.password:
bits.append("--password '%s'" % self.password)
bits.append(args)
rc, out, err = self.module.run_command(' '.join(bits), fail_on_rc_non_zero=True)
rc, out, err = self.module.run_command(' '.join(bits), check_rc=True)
return out.splitlines()
def checkout(self):