internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-07 22:02:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

zfs_facts: use check_rc (#11054)

Browse Source 
* zfs_facts: use check_rc

* add changelog frag
This commit is contained in:
Alexei Znamensky
2025-11-09 20:14:56 +13:00
committed by GitHub
parent 396f467bbb
commit 49c7253f24
2 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
changelogs/fragments/11054-zfs-facts-checkrc.yml Normal file
View File

@@ -0,0 +1,2 @@
minor_changes:
- zfs_facts - use Ansible construct to check result of external command (https://github.com/ansible-collections/community.general/pull/11054).

7
plugins/modules/zfs_facts.py
View File

@@ -193,12 +193,7 @@ class ZFSFacts:
cmd.append(",".join(self.type)) cmd.append(",".join(self.type))
cmd.extend(["-o", "name,property,value", self.properties, self.name]) cmd.extend(["-o", "name,property,value", self.properties, self.name])
(rc, out, err) = self.module.run_command(cmd) (rc, out, err) = self.module.run_command(cmd, check_rc=True)
if rc != 0:
self.module.fail_json(
msg=f"Error while trying to get facts about ZFS dataset: {self.name}", stderr=err, rc=rc
)
for line in out.splitlines(): for line in out.splitlines():
dataset, property, value = line.split("\t") dataset, property, value = line.split("\t")