VMware: Cleanup vCloud references (#56268)

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

test/integration/targets/vmware_tag/aliases

@@ -1,2 +1,2 @@
 cloud/vcenter
-unsupported
+unsupported

test/integration/targets/vmware_tag/tasks/main.yml

@@ -3,4 +3,4 @@
 # GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
 
 - include: tag_crud_ops.yml
-- include: tag_manager_ops.yml 
+- include: tag_manager_ops.yml

test/integration/targets/vmware_tag/tasks/tag_crud_ops.yml

@@ -1,12 +1,12 @@
 # Test code for the vmware_tag CRUD Operations.
 # Copyright: (c) 2019, Pavan Bidkar <pbidkar@vmware.com>
+# Copyright: (c) 2019, Abhijeet Kasurde <akasurde@redhat.com>
 # GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
 
 - when: vcsim is not defined
   block:
-
-    # Testcase Create Category
-    - name: Create Category
+    - &cat_create
+      name: Create Category
       vmware_category:
         hostname: '{{ vcenter_hostname }}'
         username: '{{ vcenter_username }}'
@@ -23,11 +23,20 @@
         that:
           - category_create.changed
 
+    - <<: *cat_create
+      name: Create category again
+
+    - name: Check if no changes are made
+      assert:
+        that:
+          - not category_create.changed
+
     - name: Set Cat_ID Paramter. Required for Tag creation
       set_fact: Cat_ID={{ category_create['category_results']['category_id'] }}
 
     # Testcase Create Tag
-    - name: Create a tag
+    - &tag_create
+      name: Create a tag
       vmware_tag:
         hostname: '{{ vcenter_hostname }}'
         username: '{{ vcenter_username }}'
@@ -44,8 +53,17 @@
         that:
           - tag_creation.changed
 
+    - <<: *tag_create
+      name: Create a tag again
+
+    - name: Check if no changes are made
+      assert:
+        that:
+          - not tag_creation.changed
+
     # Testcase Update Tag Description (reconfig)
-    - name: Update Tag Description
+    - &tag_update
+      name: Update Tag Description
       vmware_tag:
         hostname: '{{ vcenter_hostname }}'
         username: '{{ vcenter_username }}'
@@ -61,8 +79,17 @@
         that:
           - update_tag_desc.changed
 
+    - <<: *tag_update
+      name: Update tag description again
+
+    - name: Check if no changes are made
+      assert:
+        that:
+          - not update_tag_desc.changed
+
     # Testcase Delete the Tag
-    - name: Delete Tag
+    - &tag_delete
+      name: Delete Tag
       vmware_tag:
         hostname: '{{ vcenter_hostname }}'
         username: '{{ vcenter_username }}'
@@ -75,4 +102,11 @@
     - name: Check Tag is Deleted
       assert:
         that:
-          - delete_tag.changed
+          - delete_tag.changed
+    - <<: *tag_delete
+      name: Delete tag again
+
+    - name: Check if no changes are made
+      assert:
+        that:
+          - not delete_tag.changed

test/integration/targets/vmware_tag/tasks/tag_manager_ops.yml

@@ -1,11 +1,10 @@
 # Test code for the vmware_tag Manager Operations.
 # Copyright: (c) 2019, Pavan Bidkar <pbidkar@vmware.com>
+# Copyright: (c) 2019, Abhijeet Kasurde <akasurde@redhat.com>
 # GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
 
 - when: vcsim is not defined
   block:
-
-    # Get VM name to attach the tag
     - name: Get VM Facts
       vmware_vm_facts:
         hostname: '{{ vcenter_hostname }}'
@@ -17,7 +16,8 @@
     - set_fact: vm_name="{{ vm_facts['virtual_machines'][0]['guest_name'] }}"
 
     # Get Tagname
-    - name: Get facts about tag
+    - &tag_fact
+      name: Get facts about tag
       vmware_tag_facts:
         hostname: '{{ vcenter_hostname }}'
         username: '{{ vcenter_username }}'
@@ -25,12 +25,17 @@
         validate_certs: False
       register: tag_facts
 
+    - <<: *tag_fact
+      name: Get facts about tag in check mode
+      check_mode: yes
+
     - set_fact: Tag_Name={{ tag_facts['tag_facts'].keys() | list }}
 
     - debug: var=Tag_Name
 
     # Testcase Assign tag to virtual Machine
-    - name: Add tags to a virtual machine
+    - &tag_assign
+      name: Add tags to a virtual machine
       vmware_tag_manager:
         hostname: '{{ vcenter_hostname }}'
         username: '{{ vcenter_username }}'
@@ -43,7 +48,15 @@
         state: add
       register: tag_manager_ops
 
-    - name: Check Category is created
+    - name: Check tag is assign to virtual machine
       assert:
         that:
-          - tag_manager_ops.changed"
+          - tag_manager_ops.changed
+
+    - <<: *tag_assign
+      name: Add tags to a virtual machine again
+
+    - name: Check tag is not assigned to virtual machine again
+      assert:
+        that:
+          - not tag_manager_ops.changed