Miscellaneous pylint fixes.

The following rules are no longer disabled:

- bad-format-string
- duplicate-key
- lost-exception
- trailing-newlines
- unexpected-keyword-arg
- useless-suppression
- using-constant-test

test/units/modules/network/netscaler/test_netscaler_cs_action.py

@@ -41,7 +41,6 @@ class TestNetscalerCSActionModule(TestModule):
         nssrc_modules_mock = {
             'nssrc.com.citrix.netscaler.nitro.resource.config.cs': m,
             'nssrc.com.citrix.netscaler.nitro.resource.config.cs.csaction': m,
-            'nssrc.com.citrix.netscaler.nitro.resource.config.cs.csaction': m,
             'nssrc.com.citrix.netscaler.nitro.resource.config.cs.csaction.csaction': cls.cs_action_mock,
         }
 

test/units/modules/system/interfaces_file/test_interfaces_file.py

@@ -33,7 +33,6 @@ class AnsibleFailJson(Exception):
 class ModuleMocked():
     def fail_json(self, msg):
         raise AnsibleFailJson(msg)
-        pass
 
 
 module = ModuleMocked()

test/units/vars/test_variable_manager.py

@@ -104,6 +104,7 @@ class TestVariableManager(unittest.TestCase):
         # FIXME: BCS make this work
         return
 
+        # pylint: disable=unreachable
         fake_loader = DictDataLoader({})
 
         mock_task = MagicMock()
@@ -134,6 +135,8 @@ class TestVariableManager(unittest.TestCase):
     def test_variable_manager_precedence(self):
         # FIXME: this needs to be redone as dataloader is not the automatic source of data anymore
         return
+
+        # pylint: disable=unreachable
         '''
         Tests complex variations and combinations of get_vars() with different
         objects to modify the context under which variables are merged.