remove wildcards and add boilerplate

* cloud/centurylink * source_control * cloud/google * notification * cloud/rackspace * cloud/vmware
2026-05-07 22:02:50 +00:00 · 2017-07-29 08:05:38 -07:00
parent 21564cdb98
commit 4109a82d0a
135 changed files with 1343 additions and 2631 deletions
--- a/lib/ansible/modules/notification/campfire.py
+++ b/lib/ansible/modules/notification/campfire.py
@@ -1,20 +1,13 @@
 #!/usr/bin/python
 # -*- coding: utf-8 -*-
 #
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+# Copyright: Ansible Project
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type
+
+
 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['preview'],
                    'supported_by': 'community'}
@@ -81,6 +74,10 @@ EXAMPLES = '''

 import cgi

+from ansible.module_utils.basic import AnsibleModule
+from ansible.module_utils.urls import fetch_url
+
+
 def main():

    module = AnsibleModule(
@@ -144,8 +141,6 @@ def main():

    module.exit_json(changed=True, room=room, msg=msg, notify=notify)

-# import module snippets
-from ansible.module_utils.basic import *
-from ansible.module_utils.urls import *
+
 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/catapult.py
+++ b/lib/ansible/modules/notification/catapult.py
@@ -2,21 +2,13 @@
 # -*- coding: utf-8 -*-

 # (c) 2016, Jonathan Mainguy <jon@soh.re>
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
 #
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+# basis of code taken from the ansible twillio and nexmo modules
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type
+

 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['preview'],
@@ -106,9 +98,9 @@ changed:


 import json
+
 from ansible.module_utils.basic import AnsibleModule
 from ansible.module_utils.urls import fetch_url
-# Stole most of this code from the ansible twillio and nexmo modules


 def send(module, src, dest, msg, media, user_id, api_token, api_secret):
@@ -161,5 +153,6 @@ def main():
    changed = True
    module.exit_json(changed=changed)

+
 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/cisco_spark.py
+++ b/lib/ansible/modules/notification/cisco_spark.py
@@ -1,20 +1,11 @@
 #!/usr/bin/python
 # -*- coding: utf-8 -*-
 #
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+# Copyright: Ansible Project
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type


 ANSIBLE_METADATA = {'metadata_version': '1.0',
@@ -122,6 +113,8 @@ message:
    type: string
    sample: OK (585 bytes)
 """
+from ansible.module_utils.basic import AnsibleModule
+from ansible.module_utils.urls import fetch_url


 def spark_message(module):
@@ -195,7 +188,5 @@ def main():
    module.exit_json(**results)


-from ansible.module_utils.basic import AnsibleModule
-from ansible.module_utils.urls import fetch_url
 if __name__ == "__main__":
    main()
--- a/lib/ansible/modules/notification/flowdock.py
+++ b/lib/ansible/modules/notification/flowdock.py
@@ -2,21 +2,11 @@
 # -*- coding: utf-8 -*-

 # Copyright 2013 Matt Coddington <coddington@gmail.com>
-#
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type
+

 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['preview'],
@@ -110,7 +100,10 @@ EXAMPLES = '''
    tags: tag1,tag2,tag3
 '''

+from ansible.module_utils.basic import AnsibleModule
 from ansible.module_utils.six.moves.urllib.parse import urlencode
+from ansible.module_utils.urls import fetch_url
+

 # ===========================================
 # Module execution.
@@ -192,9 +185,6 @@ def main():

    module.exit_json(changed=True, msg=module.params["msg"])

-# import module snippets
-from ansible.module_utils.basic import *
-from ansible.module_utils.urls import *

 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/grove.py
+++ b/lib/ansible/modules/notification/grove.py
@@ -1,20 +1,12 @@
 #!/usr/bin/python
 # -*- coding: utf-8 -*-
 #
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+# Copyright: Ansible Project
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type
+

 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['preview'],
@@ -69,7 +61,10 @@ EXAMPLES = '''
    message=deployed {{ target }}
 '''

+from ansible.module_utils.basic import AnsibleModule
 from ansible.module_utils.six.moves.urllib.parse import urlencode
+from ansible.module_utils.urls import fetch_url
+

 BASE_URL = 'https://grove.io/api/notice/%s/'

@@ -116,9 +111,6 @@ def main():
    # Mission complete
    module.exit_json(msg="OK")

-# import module snippets
-from ansible.module_utils.basic import *
-from ansible.module_utils.urls import *

 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/hall.py
+++ b/lib/ansible/modules/notification/hall.py
@@ -2,21 +2,10 @@
 # -*- coding: utf-8 -*-

 # (c) 2015, Billy Kimble <basslines@gmail.com>
-#
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type


 ANSIBLE_METADATA = {'metadata_version': '1.0',
@@ -69,9 +58,13 @@ EXAMPLES = """
  when: ec2.instances|length > 0
  with_items: '{{ ec2.instances }}'
 """
+from ansible.module_utils.basic import AnsibleModule
+from ansible.module_utils.urls import fetch_url
+

 HALL_API_ENDPOINT  = 'https://hall.com/api/1/services/generic/%s'

+
 def send_request_to_hall(module, room_token, payload):
    headers = {'Content-Type': 'application/json'}
    payload=module.jsonify(payload)
@@ -81,6 +74,7 @@ def send_request_to_hall(module, room_token, payload):
        secure_url = HALL_API_ENDPOINT % ('[redacted]')
        module.fail_json(msg=" failed to send %s to %s: %s" % (payload, secure_url, info['msg']))

+
 def main():
    module = AnsibleModule(
        argument_spec=dict(
@@ -100,8 +94,6 @@ def main():
    send_request_to_hall(module, room_token, payload)
    module.exit_json(msg="OK")

-from ansible.module_utils.basic import *
-from ansible.module_utils.urls import *

 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/hipchat.py
+++ b/lib/ansible/modules/notification/hipchat.py
@@ -1,20 +1,13 @@
 #!/usr/bin/python
 # -*- coding: utf-8 -*-
 #
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+# Copyright: Ansible Project
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type
+
+
 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['stableinterface'],
                    'supported_by': 'community'}
@@ -103,19 +96,16 @@ EXAMPLES = '''
 # HipChat module specific support methods.
 #

-try:
-    import json
-except ImportError:
-    import simplejson as json
+import json
+import traceback

-
-# import module snippets
 from ansible.module_utils.basic import AnsibleModule
-from ansible.module_utils.pycompat24 import get_exception
 from ansible.module_utils.six.moves.urllib.parse import urlencode
 from ansible.module_utils.six.moves.urllib.request import pathname2url
+from ansible.module_utils._text import to_native
 from ansible.module_utils.urls import fetch_url

+
 DEFAULT_URI = "https://api.hipchat.com/v1"

 MSG_URI_V1 = "/rooms/message"
@@ -217,12 +207,12 @@ def main():
            send_msg_v2(module, token, room, msg_from, msg, msg_format, color, notify, api)
        else:
            send_msg_v1(module, token, room, msg_from, msg, msg_format, color, notify, api)
-    except Exception:
-        e = get_exception()
-        module.fail_json(msg="unable to send msg: %s" % e)
+    except Exception as e:
+        module.fail_json(msg="unable to send msg: %s" % to_native(e), exception=traceback.format_exc())

    changed = True
    module.exit_json(changed=changed, room=room, msg_from=msg_from, msg=msg)

+
 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/irc.py
+++ b/lib/ansible/modules/notification/irc.py
@@ -2,22 +2,11 @@
 # -*- coding: utf-8 -*-

 # (c) 2013, Jan-Piet Mens <jpmens () gmail.com>
-#
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
-#
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type
+

 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['stableinterface'],
@@ -152,8 +141,11 @@ EXAMPLES = '''
 import re
 import socket
 import ssl
+import time
+import traceback

-from time import sleep
+from ansible.module_utils.basic import AnsibleModule
+from ansible.module_utils._text import to_native


 def send_msg(msg, server='localhost', port='6667', channel=None, nick_to=[], key=None, topic=None,
@@ -219,7 +211,7 @@ def send_msg(msg, server='localhost', port='6667', channel=None, nick_to=[], key
            break
        elif time.time() - start > timeout:
            raise Exception('Timeout waiting for IRC server welcome response')
-        sleep(0.5)
+        time.sleep(0.5)

    if key:
        irc.send('JOIN %s %s\r\n' % (channel, key))
@@ -234,22 +226,22 @@ def send_msg(msg, server='localhost', port='6667', channel=None, nick_to=[], key
            break
        elif time.time() - start > timeout:
            raise Exception('Timeout waiting for IRC JOIN response')
-        sleep(0.5)
+        time.sleep(0.5)

    if topic is not None:
        irc.send('TOPIC %s :%s\r\n' % (channel, topic))
-        sleep(1)
+        time.sleep(1)

    if nick_to:
        for nick in nick_to:
            irc.send('PRIVMSG %s :%s\r\n' % (nick, message))
    if channel:
        irc.send('PRIVMSG %s :%s\r\n' % (channel, message))
-    sleep(1)
+    time.sleep(1)
    if part:
        irc.send('PART %s\r\n' % channel)
        irc.send('QUIT\r\n')
-        sleep(1)
+        time.sleep(1)
    irc.close()

 # ===========================================
@@ -303,16 +295,12 @@ def main():

    try:
        send_msg(msg, server, port, channel, nick_to, key, topic, nick, color, passwd, timeout, use_ssl, part, style)
-    except Exception:
-        e = get_exception()
-        module.fail_json(msg="unable to send to IRC: %s" % e)
+    except Exception as e:
+        module.fail_json(msg="unable to send to IRC: %s" % to_native(e), exception=traceback.format_exc())

    module.exit_json(changed=False, channel=channel, nick=nick,
                     msg=msg)

-# import module snippets
-from ansible.module_utils.basic import *
-from ansible.module_utils.pycompat24 import get_exception

 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/jabber.py
+++ b/lib/ansible/modules/notification/jabber.py
@@ -2,21 +2,10 @@
 # -*- coding: utf-8 -*-
 #
 # (c) 2015, Brian Coca <bcoca@ansible.com>
-#
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type


 ANSIBLE_METADATA = {'metadata_version': '1.0',
@@ -94,9 +83,8 @@ EXAMPLES = '''
    msg: Ansible task finished
 '''

-import os
-import re
 import time
+import traceback

 HAS_XMPP = True
 try:
@@ -104,6 +92,10 @@ try:
 except ImportError:
    HAS_XMPP = False

+from ansible.module_utils.basic import AnsibleModule
+from ansible.module_utils._text import to_native
+
+
 def main():

    module = AnsibleModule(
@@ -163,15 +155,11 @@ def main():
            conn.send(msg)
        time.sleep(1)
        conn.disconnect()
-    except Exception:
-        e = get_exception()
-        module.fail_json(msg="unable to send msg: %s" % e)
+    except Exception as e:
+        module.fail_json(msg="unable to send msg: %s" % to_native(e), exception=traceback.format_exc())

    module.exit_json(changed=False, to=to, user=user, msg=msg.getBody())

-# import module snippets
-from ansible.module_utils.basic import *
-from ansible.module_utils.pycompat24 import get_exception

 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/mail.py
+++ b/lib/ansible/modules/notification/mail.py
@@ -2,21 +2,11 @@
 # -*- coding: utf-8 -*-

 # Copyright 2012 Dag Wieers <dag@wieers.com>
-#
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type
+

 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['stableinterface'],
@@ -203,24 +193,15 @@ EXAMPLES = '''
 import os
 import smtplib
 import ssl
-
-try:
-    # Python 2.6+
-    from email import encoders
-    from email.utils import parseaddr, formataddr
-    from email.mime.base import MIMEBase
-    from email.mime.multipart import MIMEMultipart
-    from email.mime.text import MIMEText
-except ImportError:
-    # Python 2.4 & 2.5
-    from email import Encoders as encoders
-    from email.Utils import parseaddr, formataddr
-    from email.MIMEBase import MIMEBase
-    from email.MIMEMultipart import MIMEMultipart
-    from email.MIMEText import MIMEText
+import traceback
+from email import encoders
+from email.utils import parseaddr, formataddr
+from email.mime.base import MIMEBase
+from email.mime.multipart import MIMEMultipart
+from email.mime.text import MIMEText

 from ansible.module_utils.basic import AnsibleModule
-from ansible.module_utils.pycompat24 import get_exception
+from ansible.module_utils._text import to_native


 def main():
@@ -275,18 +256,18 @@ def main():
    if secure in ('never', 'try', 'starttls'):
        try:
            code, smtpmessage = smtp.connect(host, port=port)
-        except smtplib.SMTPException:
-            e = get_exception()
+        except smtplib.SMTPException as e:
            if secure == 'try':
                try:
                    smtp = smtplib.SMTP_SSL(timeout=timeout)
                    code, smtpmessage = smtp.connect(host, port=port)
                    secure_state = True
-                except ssl.SSLError:
-                    e = get_exception()
-                    module.fail_json(rc=1, msg='Unable to start an encrypted session to %s:%s: %s' % (host, port, e))
+                except ssl.SSLError as e:
+                    module.fail_json(rc=1, msg='Unable to start an encrypted session to %s:%s: %s' %
+                                     (host, port, to_native(e)), exception=traceback.format_exc())
            else:
-                module.fail_json(rc=1, msg='Unable to Connect to %s:%s: %s' % (host, port, e))
+                module.fail_json(rc=1, msg='Unable to Connect to %s:%s: %s' %
+                                 (host, port, to_native(e)), exception=traceback.format_exc())


    if (secure == 'always'):
@@ -294,16 +275,16 @@ def main():
            smtp = smtplib.SMTP_SSL(timeout=timeout)
            code, smtpmessage = smtp.connect(host, port=port)
            secure_state = True
-        except ssl.SSLError:
-            e = get_exception()
-            module.fail_json(rc=1, msg='Unable to start an encrypted session to %s:%s: %s' % (host, port, e))
+        except ssl.SSLError as e:
+            module.fail_json(rc=1, msg='Unable to start an encrypted session to %s:%s: %s' %
+                             (host, port, to_native(e)), exception=traceback.format_exc())

    if int(code) > 0:
        try:
            smtp.ehlo()
-        except smtplib.SMTPException:
-            e = get_exception()
-            module.fail_json(rc=1, msg='Helo failed for host %s:%s: %s' % (host, port, e))
+        except smtplib.SMTPException as e:
+            module.fail_json(rc=1, msg='Helo failed for host %s:%s: %s' %
+                             (host, port, to_native(e)), exception=traceback.format_exc())

        auth_flag = smtp.has_extn('AUTH')

@@ -314,9 +295,9 @@ def main():
                    smtp.ehlo()
                    auth_flag = smtp.has_extn('AUTH')
                    secure_state = True
-                except smtplib.SMTPException:
-                    e = get_exception()
-                    module.fail_json(rc=1, msg='Unable to start an encrypted session to %s:%s: %s' % (host, port, e))
+                except smtplib.SMTPException as e:
+                    module.fail_json(rc=1, msg='Unable to start an encrypted session to %s:%s: %s' %
+                                     (host, port, to_native(e)), exception=traceback.format_exc())
            else:
                if secure == 'starttls':
                    module.fail_json(rc=1, msg='StartTLS is not offered on server %s:%s' % (host, port))
@@ -385,17 +366,17 @@ def main():

                part.add_header('Content-disposition', 'attachment', filename=os.path.basename(file))
                msg.attach(part)
-            except Exception:
-                e = get_exception()
-                module.fail_json(rc=1, msg="Failed to send mail: can't attach file %s: %s" % (file, e))
+            except Exception as e:
+                module.fail_json(rc=1, msg="Failed to send mail: can't attach file %s: %s" %
+                                 (file, to_native(e)), exception=traceback.format_exc())

    composed = msg.as_string()

    try:
        smtp.sendmail(sender_addr, set(addr_list), composed)
-    except Exception:
-        e = get_exception()
-        module.fail_json(rc=1, msg='Failed to send mail to %s: %s' % (", ".join(addr_list), e))
+    except Exception as e:
+        module.fail_json(rc=1, msg='Failed to send mail to %s: %s' %
+                         (", ".join(addr_list), to_native(e)), exception=traceback.format_exc())

    smtp.quit()

--- a/lib/ansible/modules/notification/mattermost.py
+++ b/lib/ansible/modules/notification/mattermost.py
@@ -7,21 +7,12 @@
 #    # (c) 2016, René Moser <mail@renemoser.net>
 #    # (c) 2015, Stefan Berggren <nsg@nsg.cc>
 #    # (c) 2014, Ramon de la Fuente <ramon@delafuente.nl>)
+#
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type

-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.

 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['preview'],
@@ -103,6 +94,7 @@ webhook_url:
 from ansible.module_utils.basic import AnsibleModule
 from ansible.module_utils.urls import fetch_url

+
 def main():
    module = AnsibleModule(
        supports_check_mode=True,
--- a/lib/ansible/modules/notification/mqtt.py
+++ b/lib/ansible/modules/notification/mqtt.py
@@ -2,22 +2,11 @@
 # -*- coding: utf-8 -*-

 # (c) 2013, 2014, Jan-Piet Mens <jpmens () gmail.com>
-#
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
-#
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type
+

 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['preview'],
@@ -133,6 +122,9 @@ EXAMPLES = '''
 # MQTT module support methods.
 #

+import os
+import traceback
+
 HAS_PAHOMQTT = True
 try:
    import socket
@@ -140,6 +132,10 @@ try:
 except ImportError:
    HAS_PAHOMQTT = False

+from ansible.module_utils.basic import AnsibleModule
+from ansible.module_utils._text import to_native
+
+
 # ===========================================
 # Main
 #
@@ -196,7 +192,7 @@ def main():
               'keyfile': keyfile}

    try:
-        rc = mqtt.single(topic, payload,
+        mqtt.single(topic, payload,
                    qos=qos,
                    retain=retain,
                    client_id=client_id,
@@ -204,15 +200,12 @@ def main():
                    port=port,
                    auth=auth,
                    tls=tls)
-    except Exception:
-        e = get_exception()
-        module.fail_json(msg="unable to publish to MQTT broker %s" % (e))
+    except Exception as e:
+        module.fail_json(msg="unable to publish to MQTT broker %s" % to_native(e),
+                         exception=traceback.format_exc())

    module.exit_json(changed=False, topic=topic)

-# import module snippets
-from ansible.module_utils.basic import *
-from ansible.module_utils.pycompat24 import get_exception

 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/nexmo.py
+++ b/lib/ansible/modules/notification/nexmo.py
@@ -2,21 +2,11 @@
 # -*- coding: utf-8 -*-

 # (c) 2014, Matt Martz <matt@sivel.net>
-#
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type
+

 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['preview'],
@@ -75,8 +65,12 @@ EXAMPLES = """
    msg: '{{ inventory_hostname }} completed'
  delegate_to: localhost
 """
+import json

 from ansible.module_utils.six.moves.urllib.parse import urlencode
+from ansible.module_utils.basic import AnsibleModule
+from ansible.module_utils.urls import fetch_url, url_argument_spec
+

 NEXMO_API = 'https://rest.nexmo.com/sms/json'

@@ -139,9 +133,5 @@ def main():
    send_msg(module)


-# import module snippets
-from ansible.module_utils.basic import *
-from ansible.module_utils.urls import *
-
 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/osx_say.py
+++ b/lib/ansible/modules/notification/osx_say.py
@@ -2,21 +2,11 @@
 # -*- coding: utf-8 -*-

 # (c) 2013, Michael DeHaan <michael@ansible.com>
-#
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type
+

 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['stableinterface'],
@@ -53,12 +43,18 @@ EXAMPLES = '''
    voice: Zarvox
  delegate_to: localhost
 '''
+import os
+
+from ansible.module_utils.basic import AnsibleModule
+

 DEFAULT_VOICE='Alex'

+
 def say(module, msg, voice):
    module.run_command(["/usr/bin/say", msg, "--voice=%s" % (voice)], check_rc=True)

+
 def main():

    module = AnsibleModule(
@@ -79,8 +75,6 @@ def main():

    module.exit_json(msg=msg, changed=False)

-# import module snippets
-from ansible.module_utils.basic import *

 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/pushbullet.py
+++ b/lib/ansible/modules/notification/pushbullet.py
@@ -1,20 +1,12 @@
 #!/usr/bin/python
 # -*- coding: utf-8 -*-
+#
+# Copyright: Ansible Project
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type

-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.

 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['preview'],
@@ -106,6 +98,9 @@ except ImportError:
 else:
    pushbullet_found = True

+from ansible.module_utils.basic import AnsibleModule
+
+
 # ===========================================
 # Main
 #
@@ -187,8 +182,6 @@ def main():

    module.fail_json(msg="An unknown error has occurred")

-# import module snippets
-from ansible.module_utils.basic import *

 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/pushover.py
+++ b/lib/ansible/modules/notification/pushover.py
@@ -1,24 +1,11 @@
 #!/usr/bin/python
 # -*- coding: utf-8 -*-
 # Copyright (c) 2012, Jim Richardson <weaselkeeper@gmail.com>
-# All rights reserved.
-#
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type

-###

 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['preview'],
@@ -65,7 +52,9 @@ EXAMPLES = '''
  delegate_to: localhost
 '''

+from ansible.module_utils.basic import AnsibleModule
 from ansible.module_utils.six.moves.urllib.parse import urlencode
+from ansible.module_utils.urls import fetch_url


 class Pushover(object):
@@ -116,8 +105,6 @@ def main():

    module.exit_json(msg='message sent successfully: %s' % response, changed=False)

-# import module snippets
-from ansible.module_utils.basic import *
-from ansible.module_utils.urls import *
+
 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/rocketchat.py
+++ b/lib/ansible/modules/notification/rocketchat.py
@@ -5,20 +5,11 @@
 # (c) 2015, Stefan Berggren <nsg@nsg.cc>
 # (c) 2014, Ramon de la Fuente <ramon@delafuente.nl>
 #
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type
+

 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['preview'],
@@ -168,8 +159,13 @@ changed:
    sample: false
 """

+from ansible.module_utils.basic import AnsibleModule
+from ansible.module_utils.urls import fetch_url
+
+
 ROCKETCHAT_INCOMING_WEBHOOK = '%s://%s/hooks/%s'

+
 def build_payload_for_rocketchat(module, text, channel, username, icon_url, icon_emoji, link_names, color, attachments):
    payload = {}
    if color == "normal" and text is not None:
@@ -249,9 +245,6 @@ def main():

    module.exit_json(msg="OK")

-# import module snippets
-from ansible.module_utils.basic import *
-from ansible.module_utils.urls import *

 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/sendgrid.py
+++ b/lib/ansible/modules/notification/sendgrid.py
@@ -2,21 +2,11 @@
 # -*- coding: utf-8 -*-

 # (c) 2015, Matt Makai <matthew.makai@gmail.com>
-#
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type
+

 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['preview'],
@@ -140,7 +130,7 @@ EXAMPLES = '''
 # =======================================
 # sendgrid module support methods
 #
-from ansible.module_utils.six.moves.urllib.parse import urlencode
+import os

 try:
    import sendgrid
@@ -148,6 +138,12 @@ try:
 except ImportError:
    HAS_SENDGRID = False

+from ansible.module_utils.basic import AnsibleModule
+from ansible.module_utils.six.moves.urllib.parse import urlencode
+from ansible.module_utils._text import to_bytes
+from ansible.module_utils.urls import fetch_url
+
+
 def post_sendgrid_api(module, username, password, from_address, to_addresses,
        subject, body, api_key=None, cc=None, bcc=None, attachments=None,
        html_body=False, from_name=None, headers=None):
@@ -160,8 +156,7 @@ def post_sendgrid_api(module, username, password, from_address, to_addresses,
        encoded_data = urlencode(data)
        to_addresses_api = ''
        for recipient in to_addresses:
-            if isinstance(recipient, unicode):
-                recipient = recipient.encode('utf-8')
+            recipient = to_bytes(recipient, errors='surrogate_or_strict')
            to_addresses_api += '&to[]=%s' % recipient
        encoded_data += to_addresses_api

@@ -270,8 +265,6 @@ def main():

    module.exit_json(msg=subject, changed=False)

-# import module snippets
-from ansible.module_utils.basic import *
-from ansible.module_utils.urls import *
+
 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/slack.py
+++ b/lib/ansible/modules/notification/slack.py
@@ -6,20 +6,11 @@
 # (c) 2015, Stefan Berggren <nsg@nsg.cc>
 # (c) 2014, Ramon de la Fuente <ramon@delafuente.nl>
 #
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type
+

 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['stableinterface'],
@@ -180,6 +171,10 @@ EXAMPLES = """
    msg: This message has &lt;brackets&gt; &amp; ampersands in plain text.
 """

+from ansible.module_utils.basic import AnsibleModule
+from ansible.module_utils.urls import fetch_url
+
+
 OLD_SLACK_INCOMING_WEBHOOK = 'https://%s/services/hooks/incoming-webhook?token=%s'
 SLACK_INCOMING_WEBHOOK = 'https://hooks.slack.com/services/%s'

@@ -190,10 +185,12 @@ escape_table = {
    "'": "\'",
 }

+
 def escape_quotes(text):
    '''Backslash any quotes within text.'''
    return "".join(escape_table.get(c,c) for c in text)

+
 def build_payload_for_slack(module, text, channel, username, icon_url, icon_emoji, link_names, parse, color, attachments):
    payload = {}
    if color == "normal" and text is not None:
@@ -296,9 +293,6 @@ def main():

    module.exit_json(msg="OK")

-# import module snippets
-from ansible.module_utils.basic import *
-from ansible.module_utils.urls import *

 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/telegram.py
+++ b/lib/ansible/modules/notification/telegram.py
@@ -2,22 +2,10 @@
 # -*- coding: utf-8 -*-

 # (c) 2016, Artem Feofanov <artem.feofanov@gmail.com>
-#
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
-#
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type


 ANSIBLE_METADATA = {'metadata_version': '1.0',
@@ -85,7 +73,10 @@ telegram_error:
 """

 import json
+
+from ansible.module_utils.basic import AnsibleModule
 from ansible.module_utils.six.moves.urllib.parse import quote
+from ansible.module_utils.urls import fetch_url


 def main():
@@ -122,8 +113,5 @@ def main():
                         telegram_error=body['description'])


-# import module snippets
-from ansible.module_utils.basic import *
-from ansible.module_utils.urls import *
 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/twilio.py
+++ b/lib/ansible/modules/notification/twilio.py
@@ -2,21 +2,11 @@
 # -*- coding: utf-8 -*-

 # (c) 2015, Matt Makai <matthew.makai@gmail.com>
-#
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type
+

 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['preview'],
@@ -109,7 +99,11 @@ EXAMPLES = '''
 # =======================================
 # twilio module support methods
 #
+import json
+
+from ansible.module_utils.basic import AnsibleModule
 from ansible.module_utils.six.moves.urllib.parse import urlencode
+from ansible.module_utils.urls import fetch_url


 def post_twilio_api(module, account_sid, auth_token, msg, from_number,
@@ -175,8 +169,6 @@ def main():

    module.exit_json(msg=msg, changed=False)

-# import module snippets
-from ansible.module_utils.basic import *
-from ansible.module_utils.urls import *
+
 if __name__ == '__main__':
    main()
--- a/lib/ansible/modules/notification/typetalk.py
+++ b/lib/ansible/modules/notification/typetalk.py
@@ -1,20 +1,13 @@
 #!/usr/bin/python
 # -*- coding: utf-8 -*-
 #
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
+# Copyright: Ansible Project
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
+
+from __future__ import absolute_import, division, print_function
+__metaclass__ = type
+
+
 ANSIBLE_METADATA = {'metadata_version': '1.0',
                    'status': ['preview'],
                    'supported_by': 'community'}
@@ -56,17 +49,9 @@ EXAMPLES = '''
    msg: install completed
 '''

-try:
-    import json
-except ImportError:
-    try:
-        import simplejson as json
-    except ImportError:
-        json = None
+import json

-# import module snippets
 from ansible.module_utils.basic import AnsibleModule
-from ansible.module_utils.pycompat24 import get_exception
 from ansible.module_utils.six.moves.urllib.parse import urlencode
 from ansible.module_utils.urls import fetch_url, ConnectionError

@@ -109,8 +94,7 @@ def send_message(module, client_id, client_secret, topic, msg):
        }
        do_request(module, url, {'message': msg}, headers)
        return True, {'access_token': access_token}
-    except ConnectionError:
-        e = get_exception()
+    except ConnectionError as e:
        return False, e