Update bare exceptions to specify Exception.

This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.

lib/ansible/modules/monitoring/datadog_event.py

@@ -96,7 +96,7 @@ import traceback
 try:
     from datadog import initialize, api
     HAS_DATADOG = True
-except:
+except Exception:
     HAS_DATADOG = False
 
 from ansible.module_utils.basic import AnsibleModule

lib/ansible/modules/monitoring/datadog_monitor.py

@@ -144,7 +144,7 @@ import traceback
 try:
     from datadog import initialize, api
     HAS_DATADOG = True
-except:
+except Exception:
     HAS_DATADOG = False
 
 from ansible.module_utils.basic import AnsibleModule

lib/ansible/modules/monitoring/logicmonitor.py

@@ -867,7 +867,7 @@ class Collector(LogicMonitor):
                                           "arch": arch}))
                     with open(installfilepath, "w") as write_file:
                         write_file.write(installer)
-                except:
+                except Exception:
                     self.fail(msg="Unable to open installer file for writing")
             else:
                 self.module.debug("Collector installer already exists")

lib/ansible/modules/monitoring/pagerduty.py

@@ -222,7 +222,7 @@ class PagerDutyRequest(object):
     def _read_response(self, response):
         try:
             return json.loads(response.read())
-        except:
+        except Exception:
             return ""
 
 

lib/ansible/modules/monitoring/pingdom.py

@@ -71,7 +71,7 @@ EXAMPLES = '''
 try:
     import pingdom
     HAS_PINGDOM = True
-except:
+except Exception:
     HAS_PINGDOM = False
 
 from ansible.module_utils.basic import AnsibleModule

lib/ansible/modules/monitoring/sensu_silence.py

@@ -130,7 +130,7 @@ def query(module, url, check, subscription):
 
     try:
         json_out = json.loads(response.read())
-    except:
+    except Exception:
         json_out = ""
 
     return False, json_out, False
@@ -182,7 +182,7 @@ def clear(module, url, check, subscription):
 
         try:
             json_out = json.loads(response.read())
-        except:
+        except Exception:
             json_out = ""
 
         return False, json_out, True
@@ -247,7 +247,7 @@ def create(
 
         try:
             json_out = json.loads(response.read())
-        except:
+        except Exception:
             json_out = ""
 
         return False, json_out, True