docker_* tests: check API version (#48620)

* Check minimal API and docker-py versions for all docker_* tests.

* Improve docker_swarm creation/destruction for tests.

* Fail when conditions aren't met.

* Don't hardcode address for advertise_addr.

test/integration/targets/docker_config/tasks/main.yml

@@ -1,3 +1,7 @@
 ---
 - include_tasks: test_docker_config.yml
-  when: docker_api_version is version('1.30', '>=')
+  # Maximum of 1.30 (docker API version for docker_config) and 1.35 (docker API version for docker_swarm) is 1.35
+  when: docker_py_version is version('2.6.0', '>=') and docker_api_version is version('1.35', '>=')
+
+- fail: msg="Too old docker / docker-py version to run docker_config tests!"
+  when: not(docker_py_version is version('2.6.0', '>=') and docker_api_version is version('1.35', '>=')) and (ansible_distribution != 'CentOS' or ansible_distribution_major_version|int > 6)

test/integration/targets/docker_config/tasks/test_docker_config.yml

@@ -1,114 +1,116 @@
 ---
-- name: Make sure we're not already using Docker swarm
-  docker_swarm:
-    state: absent
-    force: true
+- block:
+  - name: Make sure we're not already using Docker swarm
+    docker_swarm:
+      state: absent
+      force: true
 
-- name: Create a Swarm cluster
-  docker_swarm:
-    state: present
-    advertise_addr: "{{ansible_default_ipv4.address}}"
+  - name: Create a Swarm cluster
+    docker_swarm:
+      state: present
+      advertise_addr: "{{ansible_default_ipv4.address}}"
 
-- name: Parameter name should be required
-  docker_config:
-    state: present
-  ignore_errors: yes
-  register: output
+  - name: Parameter name should be required
+    docker_config:
+      state: present
+    ignore_errors: yes
+    register: output
 
-- name: assert failure when called with no name
-  assert:
-    that:
-       - 'output.failed'
-       - 'output.msg == "missing required arguments: name"'
+  - name: assert failure when called with no name
+    assert:
+      that:
+         - 'output.failed'
+         - 'output.msg == "missing required arguments: name"'
 
-- name: Test parameters
-  docker_config:
-    name: foo
-    state: present
-  ignore_errors: yes
-  register: output
+  - name: Test parameters
+    docker_config:
+      name: foo
+      state: present
+    ignore_errors: yes
+    register: output
 
-- name: assert failure when called with no data
-  assert:
-    that:
-       - 'output.failed'
-       - 'output.msg == "state is present but all of the following are missing: data"'
+  - name: assert failure when called with no data
+    assert:
+      that:
+         - 'output.failed'
+         - 'output.msg == "state is present but all of the following are missing: data"'
 
-- name: Create config
-  docker_config:
-    name: db_password
-    data: opensesame!
-    state: present
-  register: output
+  - name: Create config
+    docker_config:
+      name: db_password
+      data: opensesame!
+      state: present
+    register: output
 
-- name: Create variable config_id
-  set_fact:
-    config_id: "{{ output.config_id }}"
+  - name: Create variable config_id
+    set_fact:
+      config_id: "{{ output.config_id }}"
 
-- name: Inspect config
-  command: "docker config inspect {{ config_id }}"
-  register: inspect
+  - name: Inspect config
+    command: "docker config inspect {{ config_id }}"
+    register: inspect
 
-- debug: var=inspect
+  - debug: var=inspect
 
-- name: assert config creation succeeded
-  assert:
-    that:
-       - "'db_password' in inspect.stdout"
-       - "'ansible_key' in inspect.stdout"
+  - name: assert config creation succeeded
+    assert:
+      that:
+         - "'db_password' in inspect.stdout"
+         - "'ansible_key' in inspect.stdout"
 
-- name: Create config again
-  docker_config:
-    name: db_password
-    data: opensesame!
-    state: present
-  register: output
+  - name: Create config again
+    docker_config:
+      name: db_password
+      data: opensesame!
+      state: present
+    register: output
 
-- name: assert create config is idempotent
-  assert:
-    that:
-       - not output.changed
+  - name: assert create config is idempotent
+    assert:
+      that:
+         - not output.changed
 
-- name: Update config
-  docker_config:
-    name: db_password
-    data: newpassword!
-    state: present
-  register: output
+  - name: Update config
+    docker_config:
+      name: db_password
+      data: newpassword!
+      state: present
+    register: output
 
-- name: assert config was updated
-  assert:
-    that:
-       - output.changed
-       - output.config_id != config_id
+  - name: assert config was updated
+    assert:
+      that:
+         - output.changed
+         - output.config_id != config_id
 
-- name: Remove config
-  docker_config:
-    name: db_password
-    state: absent
+  - name: Remove config
+    docker_config:
+      name: db_password
+      state: absent
 
-- name: Check that config is removed
-  command: "docker config inspect {{ config_id }}"
-  register: output
-  ignore_errors: yes
+  - name: Check that config is removed
+    command: "docker config inspect {{ config_id }}"
+    register: output
+    ignore_errors: yes
 
-- name: assert config was removed
-  assert:
-    that:
-      - output.failed
+  - name: assert config was removed
+    assert:
+      that:
+        - output.failed
 
-- name: Remove config
-  docker_config:
-    name: db_password
-    state: absent
-  register: output
+  - name: Remove config
+    docker_config:
+      name: db_password
+      state: absent
+    register: output
 
-- name: assert remove config is idempotent
-  assert:
-    that:
-      - not output.changed
+  - name: assert remove config is idempotent
+    assert:
+      that:
+        - not output.changed
 
-- name: Remove a Swarm cluster
-  docker_swarm:
-    state: absent
-    force: true
+  always:
+  - name: Remove a Swarm cluster
+    docker_swarm:
+      state: absent
+      force: true