Improve Python code: address unused variables (#11049)

* Address F841 (unused variable).

* Reformat.

* Add changelog fragment.

* More cleanup.

* Remove trailing whitespace.

* Readd removed code as a comment with TODO.

plugins/callback/elastic.py

@@ -145,7 +145,7 @@ class ElasticSource:
         self.host = socket.gethostname()
         try:
             self.ip_address = socket.gethostbyname(socket.gethostname())
-        except Exception as e:
+        except Exception:
             self.ip_address = None
         self.user = getpass.getuser()
 

plugins/callback/logentries.py

@@ -254,7 +254,7 @@ class CallbackModule(CallbackBase):
 
         try:
             self.token = self.get_option("token")
-        except KeyError as e:
+        except KeyError:
             self._display.warning(
                 "Logentries token was not provided, this is required for this callback to operate, disabling"
             )

plugins/callback/opentelemetry.py

@@ -210,7 +210,7 @@ class OpenTelemetrySource:
         self.host = socket.gethostname()
         try:
             self.ip_address = socket.gethostbyname(socket.gethostname())
-        except Exception as e:
+        except Exception:
             self.ip_address = None
         self.user = getpass.getuser()
 

plugins/callback/syslog_json.py

@@ -129,7 +129,7 @@ class CallbackModule(CallbackBase):
     def v2_runner_on_async_failed(self, result):
         res = result._result
         host = result._host.get_name()
-        jid = result._result.get("ansible_job_id")
+        # jid = result._result.get("ansible_job_id")
         self.logger.error(
             "%s ansible-command: task execution FAILED; host: %s; message: %s",
             self.hostname,