internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-03-26 21:33:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

nmcli: fix reordering of DNS nameservers and search suffixes (#9880)

Browse Source 
* nmcli: fix reordering of DNS nameservers and search suffixes

- Fixes #8724

* Update changelog fragment index in line with PR number

- Now I understand what that number is for

* Use correct changelog format for nmcli PR #9880
This commit is contained in:
ashleyghooper
2025-03-22 09:04:30 +13:00
committed by GitHub
parent 6a2d9ccd99
commit 3922b82a57
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/modules/nmcli.py
View File

@@ -2514,9 +2514,11 @@ class Nmcli(object):
if isinstance(current_value, list) and isinstance(value, list):
# compare values between two lists
if key in ('ipv4.addresses', 'ipv6.addresses'):
if key in ('ipv4.addresses', 'ipv6.addresses', 'ipv4.dns', 'ipv6.dns', 'ipv4.dns-search', 'ipv6.dns-search'):
# The order of IP addresses matters because the first one
# is the default source address for outbound connections.
# Similarly, the order of DNS nameservers and search
# suffixes is important.
changed |= current_value != value
else:
changed |= sorted(current_value) != sorted(value)