Enable additional pylint rules and resolve issues found. (#47221)

* Resolve unneeded-not.
* Resolve global-at-module-level.
* Resolve useless-import-alias.
* Resolve bad-whitespace.
* Resolve global-variable-not-assigned.
* Resolve logging-not-lazy.
* Resolve comparison-with-itself.
This commit is contained in:
Matt Clay
2018-10-18 13:38:08 -07:00
committed by GitHub
parent 77d32b8f57
commit 37b013aca3
29 changed files with 42 additions and 53 deletions

View File

@@ -48,7 +48,7 @@ MODULE_RESULT = {"msg": "Requested actions were successfully performed on all de
@patch('vdirect_client.rest_client.RestClient')
class RestClient ():
class RestClient:
def __init__(self, vdirect_ip=None, vdirect_user=None, vdirect_password=None, wait=None,
secondary_vdirect_ip=None, https_port=None, http_port=None,
timeout=None, https=None, strict_http_results=None,
@@ -56,7 +56,7 @@ class RestClient ():
pass
class DeviceMock ():
class DeviceMock:
def __init__(self, name, client):
self.name = name

View File

@@ -35,7 +35,7 @@ NONE_PARAMS = {'vdirect_ip': None, 'vdirect_user': None, 'vdirect_password': Non
@patch('vdirect_client.rest_client.RestClient')
class RestClient ():
class RestClient:
def __init__(self, vdirect_ip=None, vdirect_user=None, vdirect_password=None, wait=None,
secondary_vdirect_ip=None, https_port=None, http_port=None,
timeout=None, https=None, strict_http_results=None,
@@ -44,7 +44,7 @@ class RestClient ():
@patch('vdirect_client.rest_client.Template')
class Template ():
class Template:
create_from_source_result = None
upload_source_result = None
@@ -67,7 +67,7 @@ class Template ():
@patch('vdirect_client.rest_client.WorkflowTemplate')
class WorkflowTemplate ():
class WorkflowTemplate:
create_template_from_archive_result = None
update_archive_result = None

View File

@@ -47,7 +47,7 @@ MODULE_RESULT = {"msg": "Configuration template run completed.", "parameters": {
@patch('vdirect_client.rest_client.RestClient')
class RestClient ():
class RestClient:
def __init__(self, vdirect_ip=None, vdirect_user=None, vdirect_password=None, wait=None,
secondary_vdirect_ip=None, https_port=None, http_port=None,
timeout=None, https=None, strict_http_results=None,
@@ -56,7 +56,7 @@ class RestClient ():
@patch('vdirect_client.rest_client.Runnable')
class Runnable ():
class Runnable:
available_actions_result = None
action_info_result = None
runnable_objects_result = None