mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-05-08 06:12:51 +00:00
Enable additional pylint rules and resolve issues found. (#47221)
* Resolve unneeded-not. * Resolve global-at-module-level. * Resolve useless-import-alias. * Resolve bad-whitespace. * Resolve global-variable-not-assigned. * Resolve logging-not-lazy. * Resolve comparison-with-itself.
This commit is contained in:
@@ -264,11 +264,11 @@ class NetAppCDOTLicense(object):
|
||||
codes.add_new_child('license-code-v2', str_value)
|
||||
|
||||
# Remove requested licenses.
|
||||
if not len(remove_list) == 0:
|
||||
if len(remove_list) != 0:
|
||||
self.remove_licenses(remove_list)
|
||||
|
||||
# Add requested licenses
|
||||
if not len(codes.get_children()) == 0:
|
||||
if len(codes.get_children()) != 0:
|
||||
license_add.add_child_elem(codes)
|
||||
try:
|
||||
self.server.invoke_successfully(license_add,
|
||||
@@ -284,7 +284,7 @@ class NetAppCDOTLicense(object):
|
||||
self.update_licenses()
|
||||
new_license_status = self.get_licensing_status()
|
||||
|
||||
if not license_status == new_license_status:
|
||||
if license_status != new_license_status:
|
||||
changed = True
|
||||
|
||||
self.module.exit_json(changed=changed)
|
||||
|
||||
@@ -550,7 +550,7 @@ class MgmtInterface(object):
|
||||
url_address_info = socket.getaddrinfo(iface["address"], 8443)
|
||||
update_used_matching_address = any(info in url_address_info for info in address_info)
|
||||
|
||||
self._logger.info("update_used_matching_address: " + str(update_used_matching_address))
|
||||
self._logger.info("update_used_matching_address: %s", update_used_matching_address)
|
||||
|
||||
# Populate the body of the request and check for changes
|
||||
if self.enable_interface is not None:
|
||||
|
||||
Reference in New Issue
Block a user