Address issues reported by ruff check (#11043)

* Resolve E713 and E714 (not in/is tests).

* Address UP018 (unnecessary str call).

* UP045 requires Python 3.10+.

* Address UP007 (X | Y for type annotations).

* Address UP035 (import Callable from collections.abc).

* Address UP006 (t.Dict -> dict).

* Address UP009 (UTF-8 encoding comment).

* Address UP034 (extraneous parantheses).

* Address SIM910 (dict.get() with None default).

* Address F401 (unused import).

* Address UP020 (use builtin open).

* Address B009 and B010 (getattr/setattr with constant name).

* Address SIM300 (Yoda conditions).

* UP029 isn't in use anyway.

* Address FLY002 (static join).

* Address B034 (re.sub positional args).

* Address B020 (loop variable overrides input).

* Address B017 (assert raise Exception).

* Address SIM211 (if expression with false/true).

* Address SIM113 (enumerate for loop).

* Address UP036 (sys.version_info checks).

* Remove unnecessary UP039.

* Address SIM201 (not ==).

* Address SIM212 (if expr with twisted arms).

* Add changelog fragment.

* Reformat.
This commit is contained in:
Felix Fontein
2025-11-08 05:05:21 +01:00
committed by GitHub
parent f5943201b9
commit 3478863ef0
77 changed files with 196 additions and 222 deletions

View File

@@ -237,7 +237,6 @@ import hashlib
import os
import posixpath
import shutil
import io
import tempfile
import traceback
import re
@@ -503,7 +502,7 @@ class MavenDownloader:
if self.local:
parsed_url = urlparse(url)
if os.path.isfile(parsed_url.path):
with io.open(parsed_url.path, "rb") as f:
with open(parsed_url.path, "rb") as f:
return f.read()
if force:
raise ValueError(f"{failmsg} because can not find file: {url}")
@@ -630,7 +629,7 @@ class MavenDownloader:
hash = hashlib.sha1()
else:
raise ValueError(f"Unknown checksum_alg {checksum_alg}")
with io.open(file, "rb") as f:
with open(file, "rb") as f:
for chunk in iter(lambda: f.read(8192), b""):
hash.update(chunk)
return hash.hexdigest()