puppet: deprecate param timeout (#11658)

* puppet: deprecate param timeout

* add changelog frag

* Update changelogs/fragments/11658-puppet-timeout-deprecation.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>

plugins/modules/puppet.py

@@ -22,6 +22,9 @@ options:
   timeout:
     description:
       - How long to wait for C(puppet) to finish.
+      - This parameter is deprecated and will be removed in community.general 14.0.0.
+        Use the task-level C(timeout) keyword instead.
+        To suppress this deprecation warning, set O(timeout) to V("").
     type: str
     default: 30m
   puppetmaster:
@@ -240,6 +243,15 @@ def main():
     )
     p = module.params
 
+    if p["timeout"]:
+        module.deprecate(
+            'The "timeout" parameter is deprecated and will be removed in community.general 14.0.0. '
+            'Use the task-level "timeout" keyword instead. '
+            "To suppress this warning, set \"timeout: ''\" in the task.",
+            version="14.0.0",
+            collection_name="community.general",
+        )
+
     if p["manifest"]:
         if not os.path.exists(p["manifest"]):
             module.fail_json(msg=f"Manifest file {dict(manifest=p['manifest'])['manifest']} not found.")