internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-08 06:12:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Eliminate redundant module argument checks.

Browse Source
This commit is contained in:
Ash Wilson
2015-02-23 14:33:02 -06:00
committed by Matt Clay
parent 6b753c5c71
commit 23c79ed474
5 changed files with 4 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/ansible/modules/extras/cloud/rackspace/rax_mon_notification.py
View File

@@ -76,18 +76,9 @@ except ImportError:
def notification(module, state, label, notification_type, details):
if not label:
module.fail_json(msg='label is required for rax_mon_notification')
if len(label) < 1 or len(label) > 255:
module.fail_json(msg='label must be between 1 and 255 characters long')
if not notification_type:
module.fail_json(msg='you must provide a notification_type')
if not details:
module.fail_json(msg='notification details are required')
changed = False
notification = None
@@ -132,12 +123,10 @@ def notification(module, state, label, notification_type, details):
notification = cm.create_notification(notification_type,
label=label, details=details)
changed = True
elif state == 'absent':
else:
for n in existing:
n.delete()
changed = True
else:
module.fail_json(msg='state must be either "present" or "absent"')
if notification:
notification_dict = {