mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-05-06 13:22:48 +00:00
Define a module for managing E-Series settings (#41010)
There are multiple settings that are defined at a global level for E-Series systems, but don't necessarily fit with anything else. This module is intended to provide a place to encapsulate those.
This commit is contained in:
committed by
John R Barker
parent
fe14781a46
commit
1f2ae0d4cd
10
test/integration/targets/netapp_eseries_global/aliases
Normal file
10
test/integration/targets/netapp_eseries_global/aliases
Normal file
@@ -0,0 +1,10 @@
|
||||
# This test is not enabled by default, but can be utilized by defining required variables in integration_config.yml
|
||||
# Example integration_config.yml:
|
||||
# ---
|
||||
#netapp_e_api_host: 10.113.1.111:8443
|
||||
#netapp_e_api_username: admin
|
||||
#netapp_e_api_password: myPass
|
||||
#netapp_e_ssid: 1
|
||||
|
||||
unsupported
|
||||
netapp/eseries
|
||||
@@ -0,0 +1 @@
|
||||
- include_tasks: run.yml
|
||||
51
test/integration/targets/netapp_eseries_global/tasks/run.yml
Normal file
51
test/integration/targets/netapp_eseries_global/tasks/run.yml
Normal file
@@ -0,0 +1,51 @@
|
||||
# Test code for the netapp_e_iscsi_interface module
|
||||
# (c) 2018, NetApp, Inc
|
||||
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
|
||||
|
||||
- name: NetApp Test Global Settings module
|
||||
fail:
|
||||
msg: 'Please define netapp_e_api_username, netapp_e_api_password, netapp_e_api_host, and netapp_e_ssid.'
|
||||
when: netapp_e_api_username is undefined or netapp_e_api_password is undefined
|
||||
or netapp_e_api_host is undefined or netapp_e_ssid is undefined
|
||||
vars: &vars
|
||||
credentials: &creds
|
||||
api_url: "https://{{ netapp_e_api_host }}/devmgr/v2"
|
||||
api_username: "{{ netapp_e_api_username }}"
|
||||
api_password: "{{ netapp_e_api_password }}"
|
||||
ssid: "{{ netapp_e_ssid }}"
|
||||
validate_certs: no
|
||||
name: TestArray
|
||||
- name: set credentials
|
||||
set_fact:
|
||||
credentials: *creds
|
||||
|
||||
- name: Show some debug information
|
||||
debug:
|
||||
msg: "Using user={{ credentials.api_username }} on server={{ credentials.api_url }}."
|
||||
|
||||
- name: Set the name to the default
|
||||
netapp_e_global:
|
||||
<<: *creds
|
||||
|
||||
- name: Set a few different names
|
||||
netapp_e_global:
|
||||
<<: *creds
|
||||
name: "{{ item }}"
|
||||
loop:
|
||||
- a
|
||||
- x
|
||||
- "000001111122222333334444455555"
|
||||
|
||||
- name: Set an explicit name
|
||||
netapp_e_global:
|
||||
<<: *creds
|
||||
name: abc
|
||||
register: result
|
||||
|
||||
- name: Validate name
|
||||
assert:
|
||||
that: result.name == "abc"
|
||||
|
||||
- name: Restore the original name
|
||||
netapp_e_global:
|
||||
<<: *creds
|
||||
76
test/units/modules/storage/netapp/test_netapp_e_global.py
Normal file
76
test/units/modules/storage/netapp/test_netapp_e_global.py
Normal file
@@ -0,0 +1,76 @@
|
||||
# (c) 2018, NetApp Inc.
|
||||
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
|
||||
|
||||
|
||||
from ansible.modules.storage.netapp.netapp_e_global import GlobalSettings
|
||||
from units.modules.utils import AnsibleExitJson, AnsibleFailJson, ModuleTestCase, set_module_args
|
||||
|
||||
__metaclass__ = type
|
||||
from ansible.compat.tests import mock
|
||||
|
||||
|
||||
class GlobalSettingsTest(ModuleTestCase):
|
||||
REQUIRED_PARAMS = {
|
||||
'api_username': 'rw',
|
||||
'api_password': 'password',
|
||||
'api_url': 'http://localhost',
|
||||
'ssid': '1',
|
||||
}
|
||||
REQ_FUNC = 'ansible.modules.storage.netapp.netapp_e_global.request'
|
||||
|
||||
def _set_args(self, args=None):
|
||||
module_args = self.REQUIRED_PARAMS.copy()
|
||||
if args is not None:
|
||||
module_args.update(args)
|
||||
set_module_args(module_args)
|
||||
|
||||
def test_set_name(self):
|
||||
"""Ensure we can successfully set the name"""
|
||||
self._set_args(dict(name="x"))
|
||||
|
||||
expected = dict(name='y', status='online')
|
||||
namer = GlobalSettings()
|
||||
# Expecting an update
|
||||
with mock.patch(self.REQ_FUNC, return_value=(200, expected)) as req:
|
||||
with mock.patch.object(namer, 'get_name', return_value='y'):
|
||||
update = namer.update_name()
|
||||
self.assertTrue(update)
|
||||
# Expecting no update
|
||||
with mock.patch(self.REQ_FUNC, return_value=(200, expected)) as req:
|
||||
with mock.patch.object(namer, 'get_name', return_value='x'):
|
||||
update = namer.update_name()
|
||||
self.assertFalse(update)
|
||||
|
||||
# Expecting an update, but no actual calls, since we're using check_mode=True
|
||||
namer.check_mode = True
|
||||
with mock.patch(self.REQ_FUNC, return_value=(200, expected)) as req:
|
||||
with mock.patch.object(namer, 'get_name', return_value='y'):
|
||||
update = namer.update_name()
|
||||
self.assertEquals(0, req.called)
|
||||
self.assertTrue(update)
|
||||
|
||||
def test_get_name(self):
|
||||
"""Ensure we can successfully set the name"""
|
||||
self._set_args()
|
||||
|
||||
expected = dict(name='y', status='online')
|
||||
namer = GlobalSettings()
|
||||
|
||||
with mock.patch(self.REQ_FUNC, return_value=(200, expected)) as req:
|
||||
name = namer.get_name()
|
||||
self.assertEquals(name, expected['name'])
|
||||
|
||||
def test_get_name_fail(self):
|
||||
"""Ensure we can successfully set the name"""
|
||||
self._set_args()
|
||||
|
||||
expected = dict(name='y', status='offline')
|
||||
namer = GlobalSettings()
|
||||
|
||||
with self.assertRaises(AnsibleFailJson):
|
||||
with mock.patch(self.REQ_FUNC, side_effect=Exception()) as req:
|
||||
name = namer.get_name()
|
||||
|
||||
with self.assertRaises(AnsibleFailJson):
|
||||
with mock.patch(self.REQ_FUNC, return_value=(200, expected)) as req:
|
||||
update = namer.update_name()
|
||||
Reference in New Issue
Block a user