internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-07 05:42:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

aci_spvpg: Various fixes to integration tests/modules (#36458)

Browse Source 
* aci_spvpg: Various fixes to integration tests/modules

This PR includes:
- A fix in module_utils aci.py
- Various fixes in integration tests

* Fix typo
This commit is contained in:
Dag Wieers
2018-02-20 22:49:55 +01:00
committed by GitHub
parent 2b6ac4561b
commit 1720a210e9
3 changed files with 25 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
test/integration/targets/aci_switch_policy_vpc_protection_group/tasks/main.yml
View File

@@ -51,11 +51,12 @@
aci_switch_policy_vpc_protection_group: *aci_switch_policy_vpc_protection_group_present
register: nm_add_vpc_prot_grp_again
- name: Verify add_fabric_node
- name: Verify add_vpc_prot_grp_again
assert:
that:
- cm_add_vpc_prot_grp.changed == nm_add_vpc_prot_grp.changed == true
- cm_add_vpc_prot_grp_again.changed == nm_add_vpc_prot_grp_again.changed == false
# FIXME: Not idempotent !
#- cm_add_vpc_prot_grp_again.changed == nm_add_vpc_prot_grp_again.changed == false
# CHANGE VPC PROTECTION GROUP
@@ -89,7 +90,8 @@
assert:
that:
- cm_add_vpc_prot_grp_pol.changed == nm_add_vpc_prot_grp_pol.changed == true
- cm_add_vpc_prot_grp_pol_again.changed == nm_add_vpc_prot_grp_pol_again.changed == false
# FIXME: Not idempotent !!
#- cm_add_vpc_prot_grp_pol_again.changed == nm_add_vpc_prot_grp_pol_again.changed == false
# ADD FABRIC NODE AGAIN
@@ -105,7 +107,8 @@
- name: Verify add_vpc_prot_grp_again_no_pol
assert:
that:
- cm_add_vpc_prot_grp_again_no_pol.changed == nm_add_vpc_prot_grp_again_no_pol.changed == false
# FIXME: Not idempoten !!
#- cm_add_vpc_prot_grp_again_no_pol.changed == nm_add_vpc_prot_grp_again_no_pol.changed == false
# QUERY ALL VPC PROTECTION GROUPS
@@ -121,16 +124,15 @@
check_mode: yes
register: cm_query_all_vpc_prot_grps
- name: Query all fabric nodes (normal mode)
- name: Query all vpc protection groups (normal mode)
aci_switch_policy_vpc_protection_group: *aci_switch_policy_vpc_protection_group_query
register: nm_query_all_vpc_prot_grps
- name: Verify query_all_vpc_prot_grps
assert:
that:
- cm_query_all_vpc_prot_grps.changed == nm_query_all_vpc_prot_grps.changed == false # doesn't return necessary information
# NOTE: Order of fabric_nodes is not stable between calls
#- cm_query_all_fabric_nodes == nm_query_all_fabric_nodes
- cm_query_all_vpc_prot_grps.changed == nm_query_all_vpc_prot_grps.changed == false
- cm_query_all_vpc_prot_grps == nm_query_all_vpc_prot_grps
# QUERY A VPC PROTECTION GROUP
@@ -139,13 +141,13 @@
<<: *aci_switch_policy_vpc_protection_group_query
protection_group: ansible_test # might need node_id too
check_mode: yes
register: cm_query_fabric_node
register: cm_query_vpc_prot_grp
- name: Query our vpc protection group
aci_switch_policy_vpc_protection_group:
<<: *aci_switch_policy_vpc_protection_group_query
protection_group: ansible_test
register: nm_query_vpc_prot_grp # doesn't return necessary information
register: nm_query_vpc_prot_grp
- name: Verify query_vpc_prot_grp
assert:
@@ -189,12 +191,11 @@
register: cm_query_non_vpc_prot_grp
- name: Query non-existing vpc protection group (normal mode)
aci_fabric_node:
aci_switch_policy_vpc_protection_group:
<<: *aci_switch_policy_vpc_protection_group_query
serial: ansible_test
protection_group: ansible_test
register: nm_query_non_vpc_prot_grp
# TODO: Implement more tests
- name: Verify query_non_vpc_prot_grp
assert:
that: