[PR #11043/3478863e backport][stable-12] Address issues reported by ruff check (#11047)

Address issues reported by ruff check (#11043)

* Resolve E713 and E714 (not in/is tests).

* Address UP018 (unnecessary str call).

* UP045 requires Python 3.10+.

* Address UP007 (X | Y for type annotations).

* Address UP035 (import Callable from collections.abc).

* Address UP006 (t.Dict -> dict).

* Address UP009 (UTF-8 encoding comment).

* Address UP034 (extraneous parantheses).

* Address SIM910 (dict.get() with None default).

* Address F401 (unused import).

* Address UP020 (use builtin open).

* Address B009 and B010 (getattr/setattr with constant name).

* Address SIM300 (Yoda conditions).

* UP029 isn't in use anyway.

* Address FLY002 (static join).

* Address B034 (re.sub positional args).

* Address B020 (loop variable overrides input).

* Address B017 (assert raise Exception).

* Address SIM211 (if expression with false/true).

* Address SIM113 (enumerate for loop).

* Address UP036 (sys.version_info checks).

* Remove unnecessary UP039.

* Address SIM201 (not ==).

* Address SIM212 (if expr with twisted arms).

* Add changelog fragment.

* Reformat.

(cherry picked from commit 3478863ef0)

Co-authored-by: Felix Fontein <felix@fontein.de>

plugins/modules/xenserver_guest.py

@@ -802,9 +802,8 @@ class XenServerVM(XenServerObject):
                         vm_disk_params_list = [
                             disk_params for disk_params in self.vm_params["VBDs"] if disk_params["type"] == "Disk"
                         ]
-                        position = 0
 
-                        for disk_change_list in change["disks_changed"]:
+                        for position, disk_change_list in enumerate(change["disks_changed"]):
                             for disk_change in disk_change_list:
                                 vdi_ref = self.xapi_session.xenapi.VDI.get_by_uuid(
                                     vm_disk_params_list[position]["VDI"]["uuid"]
@@ -829,7 +828,6 @@ class XenServerVM(XenServerObject):
                                         ),
                                     )
 
-                            position += 1
                     elif change.get("disks_new"):
                         for position, disk_userdevice in change["disks_new"]:
                             disk_params = self.module.params["disks"][position]