mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-05-08 06:12:51 +00:00
[PR #11043/3478863e backport][stable-12] Address issues reported by ruff check (#11047)
Address issues reported by ruff check (#11043)
* Resolve E713 and E714 (not in/is tests).
* Address UP018 (unnecessary str call).
* UP045 requires Python 3.10+.
* Address UP007 (X | Y for type annotations).
* Address UP035 (import Callable from collections.abc).
* Address UP006 (t.Dict -> dict).
* Address UP009 (UTF-8 encoding comment).
* Address UP034 (extraneous parantheses).
* Address SIM910 (dict.get() with None default).
* Address F401 (unused import).
* Address UP020 (use builtin open).
* Address B009 and B010 (getattr/setattr with constant name).
* Address SIM300 (Yoda conditions).
* UP029 isn't in use anyway.
* Address FLY002 (static join).
* Address B034 (re.sub positional args).
* Address B020 (loop variable overrides input).
* Address B017 (assert raise Exception).
* Address SIM211 (if expression with false/true).
* Address SIM113 (enumerate for loop).
* Address UP036 (sys.version_info checks).
* Remove unnecessary UP039.
* Address SIM201 (not ==).
* Address SIM212 (if expr with twisted arms).
* Add changelog fragment.
* Reformat.
(cherry picked from commit 3478863ef0)
Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
@@ -275,7 +275,7 @@ def sensu_check(module, path, name, state="present", backup=False):
|
||||
|
||||
for k, v in custom_params.items():
|
||||
if k in config["checks"][name]:
|
||||
if not config["checks"][name][k] == v:
|
||||
if config["checks"][name][k] != v:
|
||||
changed = True
|
||||
reasons.append(f"`custom param {k}' was changed")
|
||||
else:
|
||||
@@ -365,7 +365,7 @@ def main():
|
||||
|
||||
module = AnsibleModule(argument_spec=arg_spec, required_together=required_together, supports_check_mode=True)
|
||||
if module.params["state"] != "absent" and module.params["command"] is None:
|
||||
module.fail_json(msg="missing required arguments: %s" % ",".join(["command"]))
|
||||
module.fail_json(msg="missing required arguments: command")
|
||||
|
||||
path = module.params["path"]
|
||||
name = module.params["name"]
|
||||
|
||||
Reference in New Issue
Block a user