[PR #11043/3478863e backport][stable-12] Address issues reported by ruff check (#11047)

Address issues reported by ruff check (#11043)

* Resolve E713 and E714 (not in/is tests).

* Address UP018 (unnecessary str call).

* UP045 requires Python 3.10+.

* Address UP007 (X | Y for type annotations).

* Address UP035 (import Callable from collections.abc).

* Address UP006 (t.Dict -> dict).

* Address UP009 (UTF-8 encoding comment).

* Address UP034 (extraneous parantheses).

* Address SIM910 (dict.get() with None default).

* Address F401 (unused import).

* Address UP020 (use builtin open).

* Address B009 and B010 (getattr/setattr with constant name).

* Address SIM300 (Yoda conditions).

* UP029 isn't in use anyway.

* Address FLY002 (static join).

* Address B034 (re.sub positional args).

* Address B020 (loop variable overrides input).

* Address B017 (assert raise Exception).

* Address SIM211 (if expression with false/true).

* Address SIM113 (enumerate for loop).

* Address UP036 (sys.version_info checks).

* Remove unnecessary UP039.

* Address SIM201 (not ==).

* Address SIM212 (if expr with twisted arms).

* Add changelog fragment.

* Reformat.

(cherry picked from commit 3478863ef0)

Co-authored-by: Felix Fontein <felix@fontein.de>

plugins/modules/rhevm.py

@@ -1078,14 +1078,13 @@ class RHEV:
 
     def setDisks(self, name, disks):
         self.__get_conn()
-        counter = 0
         bootselect = False
         for disk in disks:
             if "bootable" in disk:
                 if disk["bootable"] is True:
                     bootselect = True
 
-        for disk in disks:
+        for counter, disk in enumerate(disks):
             diskname = f"{name}_Disk{counter}_{disk.get('name', '').replace('/', '_')}"
             disksize = disk.get("size", 1)
             diskdomain = disk.get("domain", None)
@@ -1110,7 +1109,6 @@ class RHEV:
             else:
                 self.conn.set_Disk(diskname, disksize, diskinterface, diskboot)
             checkFail()
-            counter += 1
 
         return True