[PR #11043/3478863e backport][stable-12] Address issues reported by ruff check (#11047)

Address issues reported by ruff check (#11043)

* Resolve E713 and E714 (not in/is tests).

* Address UP018 (unnecessary str call).

* UP045 requires Python 3.10+.

* Address UP007 (X | Y for type annotations).

* Address UP035 (import Callable from collections.abc).

* Address UP006 (t.Dict -> dict).

* Address UP009 (UTF-8 encoding comment).

* Address UP034 (extraneous parantheses).

* Address SIM910 (dict.get() with None default).

* Address F401 (unused import).

* Address UP020 (use builtin open).

* Address B009 and B010 (getattr/setattr with constant name).

* Address SIM300 (Yoda conditions).

* UP029 isn't in use anyway.

* Address FLY002 (static join).

* Address B034 (re.sub positional args).

* Address B020 (loop variable overrides input).

* Address B017 (assert raise Exception).

* Address SIM211 (if expression with false/true).

* Address SIM113 (enumerate for loop).

* Address UP036 (sys.version_info checks).

* Remove unnecessary UP039.

* Address SIM201 (not ==).

* Address SIM212 (if expr with twisted arms).

* Add changelog fragment.

* Reformat.

(cherry picked from commit 3478863ef0)

Co-authored-by: Felix Fontein <felix@fontein.de>

plugins/modules/keycloak_user_federation.py

@@ -1044,7 +1044,7 @@ def main():
             # we remove all unwanted default mappers
             # we use ids so we dont accidently remove one of the previously updated default mapper
             for default_mapper in default_mappers:
-                if not default_mapper["id"] in [x["id"] for x in updated_mappers]:
+                if default_mapper["id"] not in [x["id"] for x in updated_mappers]:
                     kc.delete_component(default_mapper["id"], realm)
 
         after_comp["mappers"] = kc.get_components(urlencode(dict(parent=cid)), realm)
@@ -1088,7 +1088,7 @@ def main():
 
             for before_mapper in before_comp.get("mappers", []):
                 # remove unwanted existing mappers that will not be updated
-                if not before_mapper["id"] in [x["id"] for x in desired_mappers if "id" in x]:
+                if before_mapper["id"] not in [x["id"] for x in desired_mappers if "id" in x]:
                     kc.delete_component(before_mapper["id"], realm)
 
             for mapper in desired_mappers: