internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-08 06:12:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

be explicit about urllib import and remove conditional urllib(2) import

Browse Source 
urllib and urllib2 have been in the python stdlib since at least
python-2.3.  There's no reason to conditionalize it.

Fixes https://github.com/ansible/ansible/issues/11322
This commit is contained in:
Toshio Kuratomi
2015-06-19 08:59:19 -07:00
committed by Matt Clay
parent 655fa27dc7
commit 16bd2c7357
11 changed files with 23 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/ansible/modules/extras/notification/hipchat.py
View File

@@ -62,8 +62,7 @@ options:
version_added: 1.6.0
# informational: requirements for nodes
requirements: [ urllib, urllib2 ]
requirements: [ ]
author: "WAKAYAMA Shirou (@shirou), BOURDEL Paul (@pb8226)"
'''
@@ -76,6 +75,7 @@ EXAMPLES = '''
#
MSG_URI = "https://api.hipchat.com/v1/rooms/message"
import urllib
def send_msg(module, token, room, msg_from, msg, msg_format='text',
color='yellow', notify=False, api=MSG_URI):