Refactor common network shared and platform utils code into package (#33452)

* Refactor common network shared and platform specific code into package (part-1)

As per proposal #76 refactor common network shared and platform specific
code into sub-package.
https://github.com/ansible/proposals/issues/76

*  ansible.module_utils.network.common - command shared functions
*  ansible.module_utils.network.{{ platform }} - where platform is platform specific shared functions

*  Fix review comments

* Fix review comments

lib/ansible/module_utils/f5_utils.py

@@ -176,7 +176,7 @@ except ImportError:
 
 from ansible.module_utils.basic import AnsibleModule
 from ansible.module_utils.six import iteritems, with_metaclass
-from ansible.module_utils.network_common import to_list, ComplexList
+from ansible.module_utils.network.common.utils import to_list, ComplexList
 from ansible.module_utils.connection import exec_command
 from ansible.module_utils._text import to_text
 

lib/ansible/module_utils/network/aireos/aireos.py

@@ -27,7 +27,7 @@
 #
 from ansible.module_utils._text import to_text
 from ansible.module_utils.basic import env_fallback, return_values
-from ansible.module_utils.network_common import to_list, ComplexList
+from ansible.module_utils.network.common.utils import to_list, ComplexList
 from ansible.module_utils.connection import exec_command
 
 _DEVICE_CONFIGS = {}

lib/ansible/module_utils/network/aos/aos.py

@@ -32,7 +32,7 @@ This module adds shared support for Apstra AOS modules
 
 In order to use this module, include it as part of your module
 
-from ansible.module_utils.aos import (check_aos_version, get_aos_session, find_collection_item,
+from ansible.module_utils.network.aos.aos import (check_aos_version, get_aos_session, find_collection_item,
                                       content_to_dict, do_load_resource)
 
 """

lib/ansible/module_utils/network/aruba/aruba.py

@@ -27,7 +27,7 @@
 #
 from ansible.module_utils._text import to_text
 from ansible.module_utils.basic import env_fallback, return_values
-from ansible.module_utils.network_common import to_list, ComplexList
+from ansible.module_utils.network.common.utils import to_list, ComplexList
 from ansible.module_utils.connection import exec_command
 
 _DEVICE_CONFIGS = {}

lib/ansible/module_utils/network/asa/asa.py

@@ -27,7 +27,7 @@
 #
 from ansible.module_utils._text import to_text
 from ansible.module_utils.basic import env_fallback, return_values
-from ansible.module_utils.network_common import to_list, EntityCollection
+from ansible.module_utils.network.common.utils import to_list, EntityCollection
 from ansible.module_utils.connection import exec_command
 from ansible.module_utils.connection import Connection, ConnectionError
 

lib/ansible/module_utils/network/cloudengine/ce.py

@@ -34,7 +34,7 @@ import sys
 import traceback
 
 from ansible.module_utils.basic import env_fallback
-from ansible.module_utils.network_common import to_list, ComplexList
+from ansible.module_utils.network.common.utils import to_list, ComplexList
 from ansible.module_utils.connection import exec_command
 from ansible.module_utils.six import iteritems
 from ansible.module_utils._text import to_native

lib/ansible/module_utils/network/common/config.py

@@ -30,7 +30,7 @@ import hashlib
 
 from ansible.module_utils.six.moves import zip
 from ansible.module_utils._text import to_bytes, to_native
-from ansible.module_utils.network_common import to_list
+from ansible.module_utils.network.common.utils import to_list
 
 DEFAULT_COMMENT_TOKENS = ['#', '!', '/*', '*/', 'echo']
 

lib/ansible/module_utils/network/common/network.py

@@ -29,7 +29,7 @@ import traceback
 
 from ansible.module_utils.basic import AnsibleModule
 from ansible.module_utils.basic import env_fallback
-from ansible.module_utils.netcli import Cli
+from ansible.module_utils.network.common.parsing import Cli
 from ansible.module_utils._text import to_native
 from ansible.module_utils.six import iteritems
 

lib/ansible/module_utils/network/dellos10/dellos10.py

@@ -33,9 +33,9 @@ import re
 
 from ansible.module_utils._text import to_text
 from ansible.module_utils.basic import env_fallback, return_values
-from ansible.module_utils.network_common import to_list, ComplexList
+from ansible.module_utils.network.common.utils import to_list, ComplexList
 from ansible.module_utils.connection import exec_command
-from ansible.module_utils.netcfg import NetworkConfig, ConfigLine
+from ansible.module_utils.network.common.config import NetworkConfig, ConfigLine
 
 _DEVICE_CONFIGS = {}
 

lib/ansible/module_utils/network/dellos6/dellos6.py

@@ -32,9 +32,9 @@ import re
 
 from ansible.module_utils._text import to_text
 from ansible.module_utils.basic import env_fallback, return_values
-from ansible.module_utils.network_common import to_list, ComplexList
+from ansible.module_utils.network.common.utils import to_list, ComplexList
 from ansible.module_utils.connection import exec_command
-from ansible.module_utils.netcfg import NetworkConfig, ConfigLine, ignore_line, DEFAULT_COMMENT_TOKENS
+from ansible.module_utils.network.common.config import NetworkConfig, ConfigLine, ignore_line, DEFAULT_COMMENT_TOKENS
 
 _DEVICE_CONFIGS = {}
 

lib/ansible/module_utils/network/dellos9/dellos9.py

@@ -33,9 +33,9 @@ import re
 
 from ansible.module_utils._text import to_text
 from ansible.module_utils.basic import env_fallback, return_values
-from ansible.module_utils.network_common import to_list, ComplexList
+from ansible.module_utils.network.common.utils import to_list, ComplexList
 from ansible.module_utils.connection import exec_command
-from ansible.module_utils.netcfg import NetworkConfig, ConfigLine
+from ansible.module_utils.network.common.config import NetworkConfig, ConfigLine
 
 _DEVICE_CONFIGS = {}
 

lib/ansible/module_utils/network/enos/enos.py

@@ -33,7 +33,7 @@
 
 from ansible.module_utils._text import to_text
 from ansible.module_utils.basic import env_fallback, return_values
-from ansible.module_utils.network_common import to_list, EntityCollection
+from ansible.module_utils.network.common.utils import to_list, EntityCollection
 from ansible.module_utils.connection import Connection, exec_command
 from ansible.module_utils.connection import ConnectionError
 

lib/ansible/module_utils/network/eos/eos.py

@@ -33,7 +33,7 @@ import time
 from ansible.module_utils._text import to_text, to_native
 from ansible.module_utils.basic import env_fallback, return_values
 from ansible.module_utils.connection import exec_command
-from ansible.module_utils.network_common import to_list, ComplexList
+from ansible.module_utils.network.common.utils import to_list, ComplexList
 from ansible.module_utils.six import iteritems
 from ansible.module_utils.urls import fetch_url
 

lib/ansible/module_utils/network/ios/ios.py

@@ -27,7 +27,7 @@
 #
 from ansible.module_utils._text import to_text
 from ansible.module_utils.basic import env_fallback, return_values
-from ansible.module_utils.network_common import to_list, ComplexList
+from ansible.module_utils.network.common.utils import to_list, ComplexList
 from ansible.module_utils.connection import exec_command
 
 _DEVICE_CONFIGS = {}

lib/ansible/module_utils/network/iosxr/iosxr.py

@@ -28,7 +28,7 @@
 #
 from ansible.module_utils._text import to_text
 from ansible.module_utils.basic import env_fallback, return_values
-from ansible.module_utils.network_common import to_list, ComplexList
+from ansible.module_utils.network.common.utils import to_list, ComplexList
 from ansible.module_utils.connection import exec_command
 
 _DEVICE_CONFIGS = {}

lib/ansible/module_utils/network/ironware/ironware.py

@@ -21,7 +21,7 @@ __metaclass__ = type
 
 from ansible.module_utils._text import to_text
 from ansible.module_utils.basic import env_fallback, return_values
-from ansible.module_utils.network_common import to_list, EntityCollection
+from ansible.module_utils.network.common.utils import to_list, EntityCollection
 from ansible.module_utils.connection import Connection, exec_command
 
 _DEVICE_CONFIG = None

lib/ansible/module_utils/network/junos/junos.py

@@ -23,7 +23,7 @@ from copy import deepcopy
 
 from ansible.module_utils.basic import env_fallback, return_values
 from ansible.module_utils.connection import Connection
-from ansible.module_utils.netconf import NetconfConnection
+from ansible.module_utils.network.common.netconf import NetconfConnection
 from ansible.module_utils._text import to_text
 
 try:

lib/ansible/module_utils/network/mlnxos/mlnxos.py

@@ -21,7 +21,7 @@
 from ansible.module_utils._text import to_text
 from ansible.module_utils.basic import env_fallback
 from ansible.module_utils.connection import Connection, ConnectionError
-from ansible.module_utils.network_common import to_list, EntityCollection
+from ansible.module_utils.network.common.utils import to_list, EntityCollection
 
 _DEVICE_CONFIGS = {}
 _CONNECTION = None

lib/ansible/module_utils/network/nxos/nxos.py

@@ -32,7 +32,7 @@ import collections
 
 from ansible.module_utils._text import to_text
 from ansible.module_utils.basic import env_fallback, return_values
-from ansible.module_utils.network_common import to_list, ComplexList
+from ansible.module_utils.network.common.utils import to_list, ComplexList
 from ansible.module_utils.connection import exec_command
 from ansible.module_utils.six import iteritems, string_types
 from ansible.module_utils.urls import fetch_url

lib/ansible/module_utils/network/sros/sros.py

@@ -32,8 +32,7 @@ import re
 
 from ansible.module_utils._text import to_text
 from ansible.module_utils.basic import env_fallback, return_values
-from ansible.module_utils.network import NetworkError
-from ansible.module_utils.network_common import to_list, ComplexList
+from ansible.module_utils.network.common.utils import to_list, ComplexList
 from ansible.module_utils.connection import exec_command
 
 _DEVICE_CONFIGS = {}

lib/ansible/module_utils/network/vyos/vyos.py

@@ -28,7 +28,7 @@
 import json
 from ansible.module_utils._text import to_text
 from ansible.module_utils.basic import env_fallback, return_values
-from ansible.module_utils.network_common import to_list
+from ansible.module_utils.network.common.utils import to_list
 from ansible.module_utils.connection import Connection
 
 _DEVICE_CONFIGS = {}