[PR #11848/c4ed3467 backport][stable-12] homebrew_tap: fix None in command, redundant brew tap calls, format strings, and drop no-op locale vars (#11865)

homebrew_tap: fix None in command, redundant brew tap calls, format strings, and drop no-op locale vars (#11848)

* homebrew_tap: fix None in command list, redundant brew tap calls, and bad format strings

- Fix None being injected into the run_command list when url is not
  provided to add_tap (filter with [opt for opt in [...] if opt])
- Reduce redundant `brew tap` calls: add_taps and remove_taps now
  fetch the tap list once upfront and pass it to the per-tap functions;
  already_tapped accepts an optional pre-fetched list to avoid re-running
  brew for every tap in a batch
- Fix mixed f-string/%-formatting in error messages in add_taps and
  remove_taps, replaced with plain f-strings



* homebrew_tap: simplify command construction in add_tap

Replace the opaque list comprehension filter with an explicit conditional
append — only url is ever optional, so testing the known-present items
was misleading.



* homebrew_tap: remove unnecessary locale env vars

Homebrew has no i18n/l10n support — all output is hardcoded English.
LANGUAGE=C and LC_ALL=C have no effect on brew output.



* homebrew_tap: add changelog fragment for #11848



* remove hombrew_tap from PR #11783 changelog - change reverted here

---------


(cherry picked from commit c4ed3467b6)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

changelogs/fragments/11783-group5-batch12-locale.yml

@@ -5,9 +5,6 @@ bugfixes:
   - bundler - set ``LANGUAGE`` and ``LC_ALL`` to ``C`` in ``run_command()`` calls to ensure locale-independent output parsing
     (https://github.com/ansible-collections/community.general/issues/11737,
     https://github.com/ansible-collections/community.general/pull/11783).
-  - homebrew_tap - set ``LANGUAGE`` and ``LC_ALL`` to ``C`` in ``run_command()`` calls to ensure locale-independent output parsing
-    (https://github.com/ansible-collections/community.general/issues/11737,
-    https://github.com/ansible-collections/community.general/pull/11783).
   - kibana_plugin - set ``LANGUAGE`` and ``LC_ALL`` to ``C`` in ``run_command()`` calls to ensure locale-independent output parsing
     (https://github.com/ansible-collections/community.general/issues/11737,
     https://github.com/ansible-collections/community.general/pull/11783).

changelogs/fragments/11848-homebrew-tap-fixes.yml

@@ -0,0 +1,7 @@
+bugfixes:
+  - homebrew_tap - fix ``None`` being passed as a command argument when adding a tap without a URL
+    (https://github.com/ansible-collections/community.general/pull/11848).
+minor_changes:
+  - homebrew_tap - avoid redundant ``brew tap`` calls when processing multiple taps by fetching
+    the tap list once upfront
+    (https://github.com/ansible-collections/community.general/pull/11848).