internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-08 06:12:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix lvg module idempotency (#47620)

Browse Source 
* Fix lvg module idempotency

In [1] changes were made to ensure that the physical
devices were appropriately filtered, but the dev_list
which is used to prepare the filter is modified from
the original arguments to resolve any symlinks. This
results in the existing devices given in the module
args to be left out of the filter, resulting
in the module trying to add the same device again
every time the task is executed.

In this PR we change dev_list to be a copy of the
module arguments so that we're able to add the given
pv list from the module arguments into the filter
as well, ensuring that there is idempotence when
running the task again.

[1] https://github.com/ansible/ansible/pull/38446

* Add lvg module idempotence test

To ensure that the lvg module is tested for idempotency,
we add a basic integration test.

Support for MacOS and FreeBSD are skipped because the
module does not currently support those platforms.
This commit is contained in:
Jesse Pretorius
2018-11-05 12:50:21 +00:00
committed by John R Barker
parent 5b27de41bd
commit 0fc99c3939
3 changed files with 55 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/ansible/modules/system/lvg.py
View File

@@ -150,7 +150,7 @@ def main():
dev_list = []
if module.params['pvs']:
dev_list = module.params['pvs']
dev_list = list(module.params['pvs'])
elif state == 'present':
module.fail_json(msg="No physical volumes given.")
@@ -167,7 +167,7 @@ def main():
# get pv list
pvs_cmd = module.get_bin_path('pvs', True)
if dev_list:
pvs_filter = ' || '. join(['pv_name = {0}'.format(x) for x in dev_list])
pvs_filter = ' || '. join(['pv_name = {0}'.format(x) for x in dev_list + module.params['pvs']])
pvs_filter = "--select '%s'" % pvs_filter
else:
pvs_filter = ''