mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-05-06 21:32:49 +00:00
Clean up shebangs for various files.
- Remove shebangs from: - ini files - unit tests - module_utils - plugins - module_docs_fragments - non-executable Makefiles - Change non-modules from '/usr/bin/python' to '/usr/bin/env python'. - Change '/bin/env' to '/usr/bin/env'. Also removed main functions from unit tests (since they no longer have a shebang) and fixed a python 3 compatibility issue with update_bundled.py so it does not need to specify a python 2 shebang. A script was added to check for unexpected shebangs in files. This script is run during CI on Shippable.
This commit is contained in:
17
test/sanity/code-smell/shebang.sh
Executable file
17
test/sanity/code-smell/shebang.sh
Executable file
@@ -0,0 +1,17 @@
|
||||
#!/bin/sh
|
||||
|
||||
grep '^#!' -RIn . 2>/dev/null | grep ':1:' | sed 's/:1:/:/' | grep -v -E \
|
||||
-e '^\./lib/ansible/modules/' \
|
||||
-e '^\./test/integration/targets/[^/]*/library/[^/]*:#!powershell$' \
|
||||
-e ':#!/bin/sh$' \
|
||||
-e ':#!/bin/bash( -[eux]|$)' \
|
||||
-e ':#!/usr/bin/make -f$' \
|
||||
-e ':#!/usr/bin/env python$' \
|
||||
-e ':#!/usr/bin/env bash$' \
|
||||
-e ':#!/usr/bin/env fish$'
|
||||
|
||||
if [ $? -ne 1 ]; then
|
||||
echo "One or more file(s) listed above have an unexpected shebang."
|
||||
echo "See $0 for the list of acceptable values."
|
||||
exit 1
|
||||
fi
|
||||
@@ -1,5 +1,3 @@
|
||||
#!/usr/bin/python
|
||||
|
||||
from nose.plugins.skip import SkipTest
|
||||
|
||||
try:
|
||||
@@ -489,9 +487,3 @@ class AnsibleEc2VpcNatGatewayFunctions(unittest.TestCase):
|
||||
)
|
||||
self.assertFalse(success)
|
||||
self.assertFalse(changed)
|
||||
|
||||
def main():
|
||||
unittest.main()
|
||||
|
||||
if __name__ == '__main__':
|
||||
main()
|
||||
|
||||
@@ -1,5 +1,3 @@
|
||||
#!/usr/bin/python
|
||||
|
||||
from nose.plugins.skip import SkipTest
|
||||
|
||||
try:
|
||||
@@ -287,10 +285,3 @@ class AnsibleKinesisStreamFunctions(unittest.TestCase):
|
||||
self.assertTrue(changed)
|
||||
self.assertEqual(results, should_return)
|
||||
self.assertEqual(err_msg, 'Kinesis Stream test updated successfully.')
|
||||
|
||||
|
||||
def main():
|
||||
unittest.main()
|
||||
|
||||
if __name__ == '__main__':
|
||||
main()
|
||||
|
||||
@@ -1,4 +1,3 @@
|
||||
#!/usr/bin/python
|
||||
# -*- coding: utf-8 -*-
|
||||
# (c) 2016, James Cammarata <jimi@sngx.net>
|
||||
#
|
||||
|
||||
@@ -1,4 +1,3 @@
|
||||
#!/usr/bin/env python
|
||||
# -*- coding: utf-8 -*-
|
||||
# (c) 2015, Florian Apolloner <florian@apolloner.eu>
|
||||
#
|
||||
|
||||
@@ -20,6 +20,7 @@ test/sanity/code-smell/replace-urlopen.sh .
|
||||
test/sanity/code-smell/use-compat-six.sh lib
|
||||
test/sanity/code-smell/boilerplate.sh
|
||||
test/sanity/code-smell/required-and-default-attributes.sh
|
||||
test/sanity/code-smell/shebang.sh
|
||||
|
||||
shellcheck \
|
||||
test/integration/targets/*/*.sh \
|
||||
|
||||
Reference in New Issue
Block a user