internet/community.crypto
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.crypto.git synced 2026-05-06 13:22:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Validate challenges in parallel instead of serially. (#617)

Browse Source
This commit is contained in:
Felix Fontein
2023-06-09 06:04:34 +02:00
committed by GitHub
parent 3a5d9129b2
commit d823382732
3 changed files with 27 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
plugins/modules/acme_certificate.py
View File

@@ -561,6 +561,7 @@ from ansible_collections.community.crypto.plugins.module_utils.acme.account impo
from ansible_collections.community.crypto.plugins.module_utils.acme.challenges import (
combine_identifier,
split_identifier,
wait_for_validation,
Authorization,
)
@@ -747,11 +748,12 @@ class ACMECertificateClient(object):
self.authorizations.update(self.order.authorizations)
# Step 2: validate pending challenges
authzs_to_wait_for = []
for type_identifier, authz in self.authorizations.items():
if authz.status == 'pending':
identifier_type, identifier = split_identifier(type_identifier)
if self.challenge is not None:
authz.call_validate(self.client, self.challenge)
authz.call_validate(self.client, self.challenge, wait=False)
authzs_to_wait_for.append(authz)
# If there is no challenge, we must check whether the authz is valid
elif authz.status != 'valid':
authz.raise_error(
@@ -760,6 +762,9 @@ class ACMECertificateClient(object):
)
self.changed = True
# Step 3: wait for authzs to validate
wait_for_validation(authzs_to_wait_for, self.client)
def download_alternate_chains(self, cert):
alternate_chains = []
for alternate in cert.alternates: