Add isort and flake8 to CI (#869)

* Run isort.

* Clean up unused assignments.

* Add flake8 linting step.

tests/unit/plugins/module_utils/crypto/test_asn1.py

@@ -5,6 +5,8 @@
 # SPDX-License-Identifier: GPL-3.0-or-later
 
 from __future__ import absolute_import, division, print_function
+
+
 __metaclass__ = type
 
 import base64
@@ -12,10 +14,9 @@ import re
 import subprocess
 
 import pytest
-
 from ansible_collections.community.crypto.plugins.module_utils.crypto._asn1 import (
-    serialize_asn1_string_as_der,
     pack_asn1,
+    serialize_asn1_string_as_der,
 )
 
 

tests/unit/plugins/module_utils/crypto/test_cryptography_support.py

@@ -5,27 +5,27 @@
 # SPDX-License-Identifier: GPL-3.0-or-later
 
 from __future__ import absolute_import, division, print_function
+
+
 __metaclass__ = type
 
 import re
 
 import cryptography
 import pytest
-
-from cryptography.x509 import NameAttribute, oid
-
 from ansible_collections.community.crypto.plugins.module_utils.crypto.basic import (
     OpenSSLObjectError,
 )
-
 from ansible_collections.community.crypto.plugins.module_utils.crypto.cryptography_support import (
-    cryptography_get_name,
     _adjust_idn,
-    _parse_dn_component,
     _parse_dn,
+    _parse_dn_component,
+    cryptography_get_name,
 )
-
-from ansible_collections.community.crypto.plugins.module_utils.version import LooseVersion
+from ansible_collections.community.crypto.plugins.module_utils.version import (
+    LooseVersion,
+)
+from cryptography.x509 import NameAttribute, oid
 
 
 @pytest.mark.parametrize('unicode, idna, cycled_unicode', [
@@ -71,7 +71,7 @@ def test_adjust_idn(unicode, idna, cycled_unicode):
 ])
 def test_adjust_idn_fail_valueerror(value, idn_rewrite, message):
     with pytest.raises(ValueError, match=message):
-        result = _adjust_idn(value, idn_rewrite)
+        _adjust_idn(value, idn_rewrite)
 
 
 @pytest.mark.parametrize('value, idn_rewrite, message', [
@@ -86,7 +86,7 @@ def test_adjust_idn_fail_valueerror(value, idn_rewrite, message):
 ])
 def test_adjust_idn_fail_user_error(value, idn_rewrite, message):
     with pytest.raises(OpenSSLObjectError, match=message):
-        result = _adjust_idn(value, idn_rewrite)
+        _adjust_idn(value, idn_rewrite)
 
 
 def test_cryptography_get_name_invalid_prefix():
@@ -149,7 +149,7 @@ if LooseVersion('2.9') <= LooseVersion(cryptography.__version__) < LooseVersion(
 ])
 def test_parse_dn_component_failure(name, options, message):
     with pytest.raises(OpenSSLObjectError, match=u'^%s$' % re.escape(message)):
-        result = _parse_dn_component(name, **options)
+        _parse_dn_component(name, **options)
 
 
 @pytest.mark.parametrize('name, expected', [
@@ -169,4 +169,4 @@ def test_parse_dn(name, expected):
 ])
 def test_parse_dn_failure(name, message):
     with pytest.raises(OpenSSLObjectError, match=u'^%s$' % re.escape(message)):
-        result = _parse_dn(name)
+        _parse_dn(name)

tests/unit/plugins/module_utils/crypto/test_math.py

@@ -5,17 +5,18 @@
 # SPDX-License-Identifier: GPL-3.0-or-later
 
 from __future__ import absolute_import, division, print_function
+
+
 __metaclass__ = type
 
 import pytest
-
 from ansible_collections.community.crypto.plugins.module_utils.crypto.math import (
     binary_exp_mod,
-    simple_gcd,
-    quick_is_not_prime,
+    convert_bytes_to_int,
     convert_int_to_bytes,
     convert_int_to_hex,
-    convert_bytes_to_int,
+    quick_is_not_prime,
+    simple_gcd,
 )
 
 

tests/unit/plugins/module_utils/crypto/test_pem.py

@@ -5,15 +5,16 @@
 # SPDX-License-Identifier: GPL-3.0-or-later
 
 from __future__ import absolute_import, division, print_function
+
+
 __metaclass__ = type
 
 import pytest
-
 from ansible_collections.community.crypto.plugins.module_utils.crypto.pem import (
+    extract_first_pem,
     identify_pem_format,
     identify_private_key_format,
     split_pem_list,
-    extract_first_pem,
 )