Add pylint (#892)

* Move mypy/flake8/isort config files to more 'natural' places.

* Add pylint.

* Look at no-member.

* Look at pointless-* and unnecessary-pass.

* Look at useless-*.

* Lint.

plugins/modules/crypto_info.py

@@ -221,6 +221,7 @@ def add_crypto_information(module: AnsibleModule) -> dict[str, t.Any]:
         has_dsa = True
         try:
             # added later in 1.5
+            # pylint: disable-next=pointless-statement
             cryptography.hazmat.primitives.asymmetric.dsa.DSAPrivateKey.sign
             has_dsa_sign = True
         except AttributeError:
@@ -238,6 +239,7 @@ def add_crypto_information(module: AnsibleModule) -> dict[str, t.Any]:
         has_rsa = True
         try:
             # added later in 1.4
+            # pylint: disable-next=pointless-statement
             cryptography.hazmat.primitives.asymmetric.rsa.RSAPrivateKey.sign
             has_rsa_sign = True
         except AttributeError:
@@ -263,6 +265,7 @@ def add_crypto_information(module: AnsibleModule) -> dict[str, t.Any]:
         has_ed25519 = True
         try:
             # added with the primitive in 2.6
+            # pylint: disable-next=pointless-statement
             cryptography.hazmat.primitives.asymmetric.ed25519.Ed25519PrivateKey.sign
             has_ed25519_sign = True
         except AttributeError:
@@ -286,6 +289,7 @@ def add_crypto_information(module: AnsibleModule) -> dict[str, t.Any]:
         has_ed448 = True
         try:
             # added with the primitive in 2.6
+            # pylint: disable-next=pointless-statement
             cryptography.hazmat.primitives.asymmetric.ed448.Ed448PrivateKey.sign
             has_ed448_sign = True
         except AttributeError:
@@ -302,6 +306,7 @@ def add_crypto_information(module: AnsibleModule) -> dict[str, t.Any]:
 
         try:
             # added later in 2.5
+            # pylint: disable-next=pointless-statement
             cryptography.hazmat.primitives.asymmetric.x25519.X25519PrivateKey.private_bytes
             full = True
         except AttributeError:
@@ -351,6 +356,7 @@ def add_crypto_information(module: AnsibleModule) -> dict[str, t.Any]:
         has_ec = True
         try:
             # added later in 1.5
+            # pylint: disable-next=pointless-statement
             cryptography.hazmat.primitives.asymmetric.ec.EllipticCurvePrivateKey.sign
             has_ec_sign = True
         except AttributeError:

plugins/modules/ecs_certificate.py

@@ -658,7 +658,7 @@ class EcsCertificate:
         except SessionConfigurationException as e:
             module.fail_json(msg=f"Failed to initialize Entrust Provider: {e}")
         try:
-            self.ecs_client.GetAppVersion()
+            self.ecs_client.GetAppVersion()  # pylint: disable=no-member
         except RestOperationException as e:
             module.fail_json(
                 msg=f"Please verify credential information. Received exception when testing ECS connection: {e.message}"
@@ -732,19 +732,21 @@ class EcsCertificate:
             # Use serial_number to identify if certificate is an Entrust Certificate
             # with an associated tracking ID
             serial_number = f"{self.cert.serial_number:X}"
-            cert_results = self.ecs_client.GetCertificates(
+            cert_results = self.ecs_client.GetCertificates(  # pylint: disable=no-member
                 serialNumber=serial_number
             ).get("certificates", {})
             if len(cert_results) == 1:
                 self.tracking_id = cert_results[0].get("trackingId")
         except RestOperationException:
             # If we fail to find a cert by serial number, that's fine, we just do not set self.tracking_id
-            return
+            pass
 
     def set_cert_details(self, module):
         try:
-            self.cert_details = self.ecs_client.GetCertificate(
-                trackingId=self.tracking_id
+            self.cert_details = (
+                self.ecs_client.GetCertificate(  # pylint: disable=no-member
+                    trackingId=self.tracking_id
+                )
             )
             self.cert_status = self.cert_details.get("status")
             self.serial_number = self.cert_details.get("serialNumber")
@@ -828,15 +830,23 @@ class EcsCertificate:
                 try:
                     if self.request_type == "validate_only":
                         body["validateOnly"] = "true"
-                        result = self.ecs_client.NewCertRequest(Body=body)
+                        result = (
+                            self.ecs_client.NewCertRequest(  # pylint: disable=no-member
+                                Body=body
+                            )
+                        )
                     if self.request_type == "new":
-                        result = self.ecs_client.NewCertRequest(Body=body)
+                        result = (
+                            self.ecs_client.NewCertRequest(  # pylint: disable=no-member
+                                Body=body
+                            )
+                        )
                     elif self.request_type == "renew":
-                        result = self.ecs_client.RenewCertRequest(
+                        result = self.ecs_client.RenewCertRequest(  # pylint: disable=no-member
                             trackingId=self.tracking_id, Body=body
                         )
                     elif self.request_type == "reissue":
-                        result = self.ecs_client.ReissueCertRequest(
+                        result = self.ecs_client.ReissueCertRequest(  # pylint: disable=no-member
                             trackingId=self.tracking_id, Body=body
                         )
                     self.tracking_id = result.get("trackingId")

plugins/modules/ecs_domain.py

@@ -276,7 +276,7 @@ class EcsDomain:
         except SessionConfigurationException as e:
             module.fail_json(msg=f"Failed to initialize Entrust Provider: {e}")
         try:
-            self.ecs_client.GetAppVersion()
+            self.ecs_client.GetAppVersion()  # pylint: disable=no-member
         except RestOperationException as e:
             module.fail_json(
                 msg=f"Please verify credential information. Received exception when testing ECS connection: {e.message}"
@@ -310,7 +310,7 @@ class EcsDomain:
 
     def check(self, module):
         try:
-            domain_details = self.ecs_client.GetDomain(
+            domain_details = self.ecs_client.GetDomain(  # pylint: disable=no-member
                 clientId=module.params["client_id"], domain=module.params["domain_name"]
             )
             self.set_domain_details(domain_details)
@@ -355,18 +355,18 @@ class EcsDomain:
                 body["domainName"] = module.params["domain_name"]
             try:
                 if not self.domain_status:
-                    self.ecs_client.AddDomain(
+                    self.ecs_client.AddDomain(  # pylint: disable=no-member
                         clientId=module.params["client_id"], Body=body
                     )
                 else:
-                    self.ecs_client.ReverifyDomain(
+                    self.ecs_client.ReverifyDomain(  # pylint: disable=no-member
                         clientId=module.params["client_id"],
                         domain=module.params["domain_name"],
                         Body=body,
                     )
 
                 time.sleep(5)
-                result = self.ecs_client.GetDomain(
+                result = self.ecs_client.GetDomain(  # pylint: disable=no-member
                     clientId=module.params["client_id"],
                     domain=module.params["domain_name"],
                 )
@@ -393,7 +393,7 @@ class EcsDomain:
                             ):
                                 break
                     time.sleep(10)
-                    result = self.ecs_client.GetDomain(
+                    result = self.ecs_client.GetDomain(  # pylint: disable=no-member
                         clientId=module.params["client_id"],
                         domain=module.params["domain_name"],
                     )

plugins/modules/openssl_dhparam.py

@@ -188,7 +188,6 @@ class DHParameterBase:
     @abc.abstractmethod
     def _do_generate(self, module: AnsibleModule) -> None:
         """Actually generate the DH params."""
-        pass
 
     def generate(self, module: AnsibleModule) -> None:
         """Generate DH params."""