mirror of
https://github.com/ansible-collections/community.crypto.git
synced 2026-04-26 00:16:28 +00:00
openssl_csr*: fix crash for key_usage idempotency check (#935)
* Fix crash for key_usage idempotency check. * Add test.
This commit is contained in:
@@ -546,7 +546,14 @@ class CertificateSigningRequestBackend:
|
||||
return False
|
||||
params = cryptography_parse_key_usage_params(self.key_usage)
|
||||
for param, value in params.items():
|
||||
if getattr(current_keyusage_ext.value, param) != value:
|
||||
try:
|
||||
# param in ('encipher_only', 'decipher_only') can result in ValueError()
|
||||
# being raised if key_agreement == False.
|
||||
current_value = getattr(current_keyusage_ext.value, param)
|
||||
except ValueError:
|
||||
# In that case, assume that the value is False.
|
||||
current_value = False
|
||||
if current_value != value:
|
||||
return False
|
||||
return current_keyusage_ext.critical == self.key_usage_critical
|
||||
|
||||
|
||||
Reference in New Issue
Block a user