Cleanup with ruff check (#963)

* Implement improvements suggested by ruff check.

* Add ruff check to CI.

* Add changelog fragment.
This commit is contained in:
Felix Fontein
2025-10-28 07:21:11 +01:00
committed by GitHub
parent 6f0c58f483
commit 5420f9baaf
39 changed files with 198 additions and 199 deletions

View File

@@ -56,9 +56,6 @@ if t.TYPE_CHECKING:
from ansible.module_utils.basic import AnsibleModule # pragma: no cover
from ansible_collections.community.crypto.plugins.module_utils._acme.account import ( # pragma: no cover
ACMEAccount,
)
from ansible_collections.community.crypto.plugins.module_utils._acme.backends import ( # pragma: no cover
CertificateInformation,
CryptoBackend,
@@ -132,12 +129,10 @@ def _is_failed(
) -> bool:
if info["status"] < 200 or info["status"] >= 400:
return True
if (
return bool(
expected_status_codes is not None
and info["status"] not in expected_status_codes
):
return True
return False
)
class ACMEDirectory:

View File

@@ -46,7 +46,7 @@ class CertificateChain:
@classmethod
def download(
cls: t.Type[_CertificateChain], *, client: ACMEClient, url: str
cls: type[_CertificateChain], *, client: ACMEClient, url: str
) -> _CertificateChain:
content, info = client.get_request(
url,

View File

@@ -82,7 +82,7 @@ class Challenge:
@classmethod
def from_json(
cls: t.Type[_Challenge],
cls: type[_Challenge],
*,
client: ACMEClient,
data: dict[str, t.Any],
@@ -188,7 +188,7 @@ class Authorization:
@classmethod
def from_json(
cls: t.Type[_Authorization],
cls: type[_Authorization],
*,
client: ACMEClient,
data: dict[str, t.Any],
@@ -200,7 +200,7 @@ class Authorization:
@classmethod
def from_url(
cls: t.Type[_Authorization], *, client: ACMEClient, url: str
cls: type[_Authorization], *, client: ACMEClient, url: str
) -> _Authorization:
result = cls(url=url)
result.refresh(client=client)
@@ -208,7 +208,7 @@ class Authorization:
@classmethod
def create(
cls: t.Type[_Authorization],
cls: type[_Authorization],
*,
client: ACMEClient,
identifier_type: str,
@@ -384,7 +384,7 @@ class Authorization:
@classmethod
def deactivate_url(
cls: t.Type[_Authorization], *, client: ACMEClient, url: str
cls: type[_Authorization], *, client: ACMEClient, url: str
) -> _Authorization:
"""
Deactivates this authorization.

View File

@@ -63,21 +63,21 @@ class Order:
@classmethod
def from_json(
cls: t.Type[_Order], *, client: ACMEClient, data: dict[str, t.Any], url: str
cls: type[_Order], *, client: ACMEClient, data: dict[str, t.Any], url: str
) -> _Order:
result = cls(url=url)
result._setup(client=client, data=data)
return result
@classmethod
def from_url(cls: t.Type[_Order], *, client: ACMEClient, url: str) -> _Order:
def from_url(cls: type[_Order], *, client: ACMEClient, url: str) -> _Order:
result = cls(url=url)
result.refresh(client=client)
return result
@classmethod
def create(
cls: t.Type[_Order],
cls: type[_Order],
*,
client: ACMEClient,
identifiers: list[tuple[str, str]],
@@ -117,7 +117,7 @@ class Order:
@classmethod
def create_with_error_handling(
cls: t.Type[_Order],
cls: type[_Order],
*,
client: ACMEClient,
identifiers: list[tuple[str, str]],