mirror of
https://github.com/ansible-collections/community.crypto.git
synced 2026-05-08 06:13:03 +00:00
Work on issues found by pylint (#896)
* Look at possibly-used-before-assignment. * Use latest beta releases of ansible-core 2.19 for mypy and pylint. * Look at unsupported-*. * Look at unknown-option-value. * Look at redefined-builtin. * Look at superfluous-parens. * Look at unspecified-encoding. * Adjust to new cryptography version and to ansible-core 2.17's pylint. * Look at super-with-arguments. * Look at no-else-*. * Look at try-except-raise. * Look at inconsistent-return-statements. * Look at redefined-outer-name. * Look at redefined-argument-from-local. * Look at attribute-defined-outside-init. * Look at unused-variable. * Look at protected-access. * Look at raise-missing-from. * Look at arguments-differ. * Look at useless-suppression and use-symbolic-message-instead. * Look at consider-using-dict-items. * Look at consider-using-in. * Look at consider-using-set-comprehension. * Look at consider-using-with. * Look at use-dict-literal.
This commit is contained in:
@@ -267,7 +267,7 @@ if t.TYPE_CHECKING:
|
||||
|
||||
class CertificateAbsent(OpenSSLObject):
|
||||
def __init__(self, module: AnsibleModule) -> None:
|
||||
super(CertificateAbsent, self).__init__(
|
||||
super().__init__(
|
||||
path=module.params["path"],
|
||||
state=module.params["state"],
|
||||
force=module.params["force"],
|
||||
@@ -284,7 +284,7 @@ class CertificateAbsent(OpenSSLObject):
|
||||
def remove(self, module: AnsibleModule) -> None:
|
||||
if self.backup:
|
||||
self.backup_file = module.backup_local(self.path)
|
||||
super(CertificateAbsent, self).remove(module)
|
||||
super().remove(module)
|
||||
|
||||
def dump(self, check_mode: bool = False) -> dict[str, t.Any]:
|
||||
result = {
|
||||
@@ -305,7 +305,7 @@ class GenericCertificate(OpenSSLObject):
|
||||
"""Retrieve a certificate using the given module backend."""
|
||||
|
||||
def __init__(self, module: AnsibleModule, module_backend: CertificateBackend):
|
||||
super(GenericCertificate, self).__init__(
|
||||
super().__init__(
|
||||
path=module.params["path"],
|
||||
state=module.params["state"],
|
||||
force=module.params["force"],
|
||||
@@ -339,12 +339,10 @@ class GenericCertificate(OpenSSLObject):
|
||||
file_args, self.changed
|
||||
)
|
||||
|
||||
def check(self, module: AnsibleModule, perms_required: bool = True) -> bool:
|
||||
def check(self, module: AnsibleModule, *, perms_required: bool = True) -> bool:
|
||||
"""Ensure the resource is in its desired state."""
|
||||
return (
|
||||
super(GenericCertificate, self).check(
|
||||
module=module, perms_required=perms_required
|
||||
)
|
||||
super().check(module=module, perms_required=perms_required)
|
||||
and not self.module_backend.needs_regeneration()
|
||||
)
|
||||
|
||||
@@ -368,12 +366,16 @@ def main() -> t.NoReturn:
|
||||
add_ownca_provider_to_argument_spec(argument_spec)
|
||||
add_selfsigned_provider_to_argument_spec(argument_spec)
|
||||
argument_spec.argument_spec.update(
|
||||
dict(
|
||||
state=dict(type="str", default="present", choices=["present", "absent"]),
|
||||
path=dict(type="path", required=True),
|
||||
backup=dict(type="bool", default=False),
|
||||
return_content=dict(type="bool", default=False),
|
||||
)
|
||||
{
|
||||
"state": {
|
||||
"type": "str",
|
||||
"default": "present",
|
||||
"choices": ["present", "absent"],
|
||||
},
|
||||
"path": {"type": "path", "required": True},
|
||||
"backup": {"type": "bool", "default": False},
|
||||
"return_content": {"type": "bool", "default": False},
|
||||
}
|
||||
)
|
||||
argument_spec.required_if.append(("state", "present", ["provider"]))
|
||||
module = argument_spec.create_ansible_module(
|
||||
|
||||
Reference in New Issue
Block a user