Work on issues found by pylint (#896)

* Look at possibly-used-before-assignment.

* Use latest beta releases of ansible-core 2.19 for mypy and pylint.

* Look at unsupported-*.

* Look at unknown-option-value.

* Look at redefined-builtin.

* Look at superfluous-parens.

* Look at unspecified-encoding.

* Adjust to new cryptography version and to ansible-core 2.17's pylint.

* Look at super-with-arguments.

* Look at no-else-*.

* Look at try-except-raise.

* Look at inconsistent-return-statements.

* Look at redefined-outer-name.

* Look at redefined-argument-from-local.

* Look at attribute-defined-outside-init.

* Look at unused-variable.

* Look at protected-access.

* Look at raise-missing-from.

* Look at arguments-differ.

* Look at useless-suppression and use-symbolic-message-instead.

* Look at consider-using-dict-items.

* Look at consider-using-in.

* Look at consider-using-set-comprehension.

* Look at consider-using-with.

* Look at use-dict-literal.

plugins/modules/openssl_dhparam.py

@@ -252,7 +252,7 @@ class DHParameterBase:
 class DHParameterAbsent(DHParameterBase):
 
     def __init__(self, module: AnsibleModule) -> None:
-        super(DHParameterAbsent, self).__init__(module)
+        super().__init__(module)
 
     def _do_generate(self, module: AnsibleModule) -> None:
         """Actually generate the DH params."""
@@ -265,7 +265,7 @@ class DHParameterAbsent(DHParameterBase):
 class DHParameterOpenSSL(DHParameterBase):
 
     def __init__(self, module: AnsibleModule) -> None:
-        super(DHParameterOpenSSL, self).__init__(module)
+        super().__init__(module)
         self.openssl_bin = module.get_bin_path("openssl", True)
 
     def _do_generate(self, module: AnsibleModule) -> None:
@@ -320,7 +320,7 @@ class DHParameterOpenSSL(DHParameterBase):
 class DHParameterCryptography(DHParameterBase):
 
     def __init__(self, module: AnsibleModule) -> None:
-        super(DHParameterCryptography, self).__init__(module)
+        super().__init__(module)
 
     def _do_generate(self, module: AnsibleModule) -> None:
         """Actually generate the DH params."""
@@ -359,17 +359,23 @@ def main() -> t.NoReturn:
     """Main function"""
 
     module = AnsibleModule(
-        argument_spec=dict(
-            state=dict(type="str", default="present", choices=["absent", "present"]),
-            size=dict(type="int", default=4096),
-            force=dict(type="bool", default=False),
-            path=dict(type="path", required=True),
-            backup=dict(type="bool", default=False),
-            select_crypto_backend=dict(
-                type="str", default="auto", choices=["auto", "cryptography", "openssl"]
-            ),
-            return_content=dict(type="bool", default=False),
-        ),
+        argument_spec={
+            "state": {
+                "type": "str",
+                "default": "present",
+                "choices": ["absent", "present"],
+            },
+            "size": {"type": "int", "default": 4096},
+            "force": {"type": "bool", "default": False},
+            "path": {"type": "path", "required": True},
+            "backup": {"type": "bool", "default": False},
+            "select_crypto_backend": {
+                "type": "str",
+                "default": "auto",
+                "choices": ["auto", "cryptography", "openssl"],
+            },
+            "return_content": {"type": "bool", "default": False},
+        },
         supports_check_mode=True,
         add_file_common_args=True,
     )