Work on issues found by pylint (#896)

* Look at possibly-used-before-assignment.

* Use latest beta releases of ansible-core 2.19 for mypy and pylint.

* Look at unsupported-*.

* Look at unknown-option-value.

* Look at redefined-builtin.

* Look at superfluous-parens.

* Look at unspecified-encoding.

* Adjust to new cryptography version and to ansible-core 2.17's pylint.

* Look at super-with-arguments.

* Look at no-else-*.

* Look at try-except-raise.

* Look at inconsistent-return-statements.

* Look at redefined-outer-name.

* Look at redefined-argument-from-local.

* Look at attribute-defined-outside-init.

* Look at unused-variable.

* Look at protected-access.

* Look at raise-missing-from.

* Look at arguments-differ.

* Look at useless-suppression and use-symbolic-message-instead.

* Look at consider-using-dict-items.

* Look at consider-using-in.

* Look at consider-using-set-comprehension.

* Look at consider-using-with.

* Look at use-dict-literal.

plugins/module_utils/_ecs/api.py

@@ -43,16 +43,20 @@ valid_file_format = re.compile(r".*(\.)(yml|yaml|json)$")
 
 
 def ecs_client_argument_spec() -> dict[str, t.Any]:
-    return dict(
-        entrust_api_user=dict(type="str", required=True),
-        entrust_api_key=dict(type="str", required=True, no_log=True),
-        entrust_api_client_cert_path=dict(type="path", required=True),
-        entrust_api_client_cert_key_path=dict(type="path", required=True, no_log=True),
-        entrust_api_specification_path=dict(
-            type="path",
-            default="https://cloud.entrust.net/EntrustCloud/documentation/cms-api-2.1.0.yaml",
-        ),
-    )
+    return {
+        "entrust_api_user": {"type": "str", "required": True},
+        "entrust_api_key": {"type": "str", "required": True, "no_log": True},
+        "entrust_api_client_cert_path": {"type": "path", "required": True},
+        "entrust_api_client_cert_key_path": {
+            "type": "path",
+            "required": True,
+            "no_log": True,
+        },
+        "entrust_api_specification_path": {
+            "type": "path",
+            "default": "https://cloud.entrust.net/EntrustCloud/documentation/cms-api-2.1.0.yaml",
+        },
+    }
 
 
 class SessionConfigurationException(Exception):
@@ -182,8 +186,7 @@ class RestOperation:
         if result or result == {}:
             if result_code and result_code < 400:
                 return result
-            else:
-                raise RestOperationException(result)
+            raise RestOperationException(result)
 
         # Raise a generic RestOperationException if this fails
         raise RestOperationException(
@@ -323,9 +326,9 @@ class ECSSession:
             except HTTPError as e:
                 raise SessionConfigurationException(
                     f"Error downloading specification from address '{entrust_api_specification_path}', received error code '{e.getcode()}'"
-                )
+                ) from e
         else:
-            with open(entrust_api_specification_path) as f:
+            with open(entrust_api_specification_path, "rb") as f:
                 if ".json" in entrust_api_specification_path:
                     self._spec = json.load(f)
                 elif (