Work on issues found by pylint (#896)

* Look at possibly-used-before-assignment.

* Use latest beta releases of ansible-core 2.19 for mypy and pylint.

* Look at unsupported-*.

* Look at unknown-option-value.

* Look at redefined-builtin.

* Look at superfluous-parens.

* Look at unspecified-encoding.

* Adjust to new cryptography version and to ansible-core 2.17's pylint.

* Look at super-with-arguments.

* Look at no-else-*.

* Look at try-except-raise.

* Look at inconsistent-return-statements.

* Look at redefined-outer-name.

* Look at redefined-argument-from-local.

* Look at attribute-defined-outside-init.

* Look at unused-variable.

* Look at protected-access.

* Look at raise-missing-from.

* Look at arguments-differ.

* Look at useless-suppression and use-symbolic-message-instead.

* Look at consider-using-dict-items.

* Look at consider-using-in.

* Look at consider-using-set-comprehension.

* Look at consider-using-with.

* Look at use-dict-literal.

plugins/module_utils/_crypto/module_backends/certificate_ownca.py

@@ -63,7 +63,7 @@ except ImportError:
 
 class OwnCACertificateBackendCryptography(CertificateBackend):
     def __init__(self, *, module: AnsibleModule) -> None:
-        super(OwnCACertificateBackendCryptography, self).__init__(module=module)
+        super().__init__(module=module)
 
         self.create_subject_key_identifier: t.Literal[
             "create_if_not_provided", "always_create", "never_create"
@@ -223,7 +223,7 @@ class OwnCACertificateBackendCryptography(CertificateBackend):
         not_before: datetime.datetime | None = None,
         not_after: datetime.datetime | None = None,
     ) -> bool:
-        if super(OwnCACertificateBackendCryptography, self).needs_regeneration(
+        if super().needs_regeneration(
             not_before=self.notBefore, not_after=self.notAfter
         ):
             return True
@@ -272,9 +272,7 @@ class OwnCACertificateBackendCryptography(CertificateBackend):
         return False
 
     def dump(self, *, include_certificate: bool) -> dict[str, t.Any]:
-        result = super(OwnCACertificateBackendCryptography, self).dump(
-            include_certificate=include_certificate
-        )
+        result = super().dump(include_certificate=include_certificate)
         result.update(
             {
                 "ca_cert": self.ca_cert_path,
@@ -343,23 +341,23 @@ class OwnCACertificateProvider(CertificateProvider):
 def add_ownca_provider_to_argument_spec(argument_spec: ArgumentSpec) -> None:
     argument_spec.argument_spec["provider"]["choices"].append("ownca")
     argument_spec.argument_spec.update(
-        dict(
-            ownca_path=dict(type="path"),
-            ownca_content=dict(type="str"),
-            ownca_privatekey_path=dict(type="path"),
-            ownca_privatekey_content=dict(type="str", no_log=True),
-            ownca_privatekey_passphrase=dict(type="str", no_log=True),
-            ownca_digest=dict(type="str", default="sha256"),
-            ownca_version=dict(type="int", default=3, choices=[3]),  # not used
-            ownca_not_before=dict(type="str", default="+0s"),
-            ownca_not_after=dict(type="str", default="+3650d"),
-            ownca_create_subject_key_identifier=dict(
-                type="str",
-                default="create_if_not_provided",
-                choices=["create_if_not_provided", "always_create", "never_create"],
-            ),
-            ownca_create_authority_key_identifier=dict(type="bool", default=True),
-        )
+        {
+            "ownca_path": {"type": "path"},
+            "ownca_content": {"type": "str"},
+            "ownca_privatekey_path": {"type": "path"},
+            "ownca_privatekey_content": {"type": "str", "no_log": True},
+            "ownca_privatekey_passphrase": {"type": "str", "no_log": True},
+            "ownca_digest": {"type": "str", "default": "sha256"},
+            "ownca_version": {"type": "int", "default": 3, "choices": [3]},  # not used
+            "ownca_not_before": {"type": "str", "default": "+0s"},
+            "ownca_not_after": {"type": "str", "default": "+3650d"},
+            "ownca_create_subject_key_identifier": {
+                "type": "str",
+                "default": "create_if_not_provided",
+                "choices": ["create_if_not_provided", "always_create", "never_create"],
+            },
+            "ownca_create_authority_key_identifier": {"type": "bool", "default": True},
+        }
     )
     argument_spec.mutually_exclusive.extend(
         [