Work on issues found by pylint (#896)

* Look at possibly-used-before-assignment.

* Use latest beta releases of ansible-core 2.19 for mypy and pylint.

* Look at unsupported-*.

* Look at unknown-option-value.

* Look at redefined-builtin.

* Look at superfluous-parens.

* Look at unspecified-encoding.

* Adjust to new cryptography version and to ansible-core 2.17's pylint.

* Look at super-with-arguments.

* Look at no-else-*.

* Look at try-except-raise.

* Look at inconsistent-return-statements.

* Look at redefined-outer-name.

* Look at redefined-argument-from-local.

* Look at attribute-defined-outside-init.

* Look at unused-variable.

* Look at protected-access.

* Look at raise-missing-from.

* Look at arguments-differ.

* Look at useless-suppression and use-symbolic-message-instead.

* Look at consider-using-dict-items.

* Look at consider-using-in.

* Look at consider-using-set-comprehension.

* Look at consider-using-with.

* Look at use-dict-literal.

plugins/module_utils/_acme/io.py

@@ -29,7 +29,7 @@ def read_file(fn: str | os.PathLike) -> bytes:
         with open(fn, "rb") as f:
             return f.read()
     except Exception as e:
-        raise ModuleFailException(f'Error while reading file "{fn}": {e}')
+        raise ModuleFailException(f'Error while reading file "{fn}": {e}') from e
 
 
 # This function was adapted from an earlier version of https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/uri.py
@@ -55,7 +55,7 @@ def write_file(
         raise ModuleFailException(
             f"failed to create temporary content file: {err}",
             exception=traceback.format_exc(),
-        )
+        ) from err
     f.close()
     checksum_src = None
     checksum_dest = None
@@ -94,7 +94,7 @@ def write_file(
             raise ModuleFailException(
                 f"failed to copy {tmpsrc} to {dest}: {err}",
                 exception=traceback.format_exc(),
-            )
+            ) from err
     os.remove(tmpsrc)
     return changed